Add POSIX-safe init, runner fixes, and full contribution guidelines #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnarapar
reviewed
May 26, 2025
vnarapar
reviewed
May 26, 2025
vnarapar
reviewed
May 26, 2025
vnarapar
reviewed
May 26, 2025
vnarapar
reviewed
May 26, 2025
vnarapar
reviewed
May 26, 2025
vnarapar
reviewed
May 26, 2025
vnarapar
reviewed
May 26, 2025
vnarapar
reviewed
May 26, 2025
|
We are not really removing the Copyright & License. We are making a clean up. Please ignore this error, we will make a note & update the checker to handle such scenarios. |
… logic - Updated init_env to dynamically resolve the root directory using presence of utils/ and suites/ - Enhanced run-test.sh to be fully POSIX-compliant and standalone-friendly - Ensures both scripts work without requiring a .git repo or fixed working directory - Improved robustness for embedded/CI environments Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
|
@vnarapar @abbajaj806 The latest patch addresses all review comments. |
abbajaj806
reviewed
May 27, 2025
- Added POSIX-compliant detection of utils/ directory via SCRIPT_DIR - init_env is now sourced only if present, preventing runtime errors on target - Ensures compatibility with CI, embedded targets, and non-Git environments - Preserved function structure for log and test discovery utilities Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
- Updated all run.sh scripts to dynamically locate testkit root using utils/ and suites/ markers - Replaced hardcoded relative paths with SCRIPT_DIR and ROOT_DIR detection logic - Ensures consistent behavior across local, CI, and target environments - Retains compatibility with functestlib.sh and init_env Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
…llCheck compliance - Moved CONTRIBUTING.md to doc-friendly format - Added sample run.sh pseudocode with .res file requirement - Clarified folder structure and naming conventions - Included ShellCheck enforcement and POSIX shell compatibility - Outlined expectations for CI/CD and result file parsing Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
|
@abbajaj806 this commit |
abbajaj806
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several enhancements for maintainability and contributor onboarding:
init_env was updated to prevent duplicate sourcing and repeated log output using __INIT_ENV_LOADED and NO_INIT_LOG
run-test.sh was rewritten for full POSIX compliance and consistent test execution behavior
functestlib.sh and related sourcing paths were aligned and ShellCheck warnings disabled where needed
A new CONTRIBUTING.md file outlines the required folder structure, .res result handling for CI/CD, ShellCheck rules, and test logging standards
These changes help standardize shell-based test contributions and prepare the repo for broader automation and LAVA integration.