Added Kernel Level testcases #48

vnarapar · 2025-05-26T06:00:27Z

Added the below testcases

DCVS testcase
CPU_Affinity testcase from Scheduler
Enhanced existing IOMMU test

smuppand · 2025-05-26T07:15:29Z

Runner/suites/Kernel/FunctionalArea/baseport/DCVS/run.sh

+        exit 1
+    fi
+done
+


Better move this logic to functestlib.sh

Moved his function to functestlib.sh

smuppand

Move DCVS out of baseport and create under FunctionaArea

smuppand · 2025-05-26T07:19:05Z

Runner/suites/Kernel/FunctionalArea/baseport/iommu/run.sh

+    fi
+    return 0
+}
+


This can be moved to functestlib.sh

Moved his function to functestlib.sh

smuppand · 2025-05-26T07:19:30Z

Runner/suites/Kernel/FunctionalArea/baseport/iommu/run.sh

+    return 0
+}
+
+check_dt_nodes() {


This can also be moved to functestlib.sh

Moved his function to functestlib.sh

smuppand · 2025-05-26T07:19:52Z

Runner/suites/Kernel/FunctionalArea/baseport/iommu/run.sh

+    return 1
+}
+
+check_driver_loaded() {


This also can be moved to functestlib.sh

moved to functestlib.sh

smuppand · 2025-05-28T05:57:27Z

Runner/utils/functestlib.sh

@@ -48,6 +48,17 @@ find_test_case_script_by_name() {
    find "$base_dir" -type d -iname "$test_name" -print -quit 2>/dev/null
 }

+check_kernel_config() {


Some Improvements can be done.

Add ; or line breaks for POSIX shell between statements.

Always quote variables in command substitutions.

Use return 1 right after logging failure, and only one return at the end.

Good idea to log both PASS and FAIL for clear CI visibility.

if you want it extended for “=m” (module) configs as well!

smuppand · 2025-05-28T07:07:29Z

Runner/suites/Kernel/FunctionalArea/baseport/iommu/run.sh

+check_kernel_config "CONFIG_IOMMU_SUPPORT" || pass=false
+check_kernel_config "CONFIG_QCOM_IOMMU" || pass=false
+check_kernel_config "CONFIG_ARM_SMMU" || pass=false
+


Replace with a loop for easier maintenance.

Removed this and added loops

smuppand · 2025-05-28T15:03:21Z

Runner/suites/Kernel/FunctionalArea/baseport/iommu/run.sh

+
+CONFIGS="CONFIG_IOMMU_SUPPORT CONFIG_QCOM_IOMMU CONFIG_ARM_SMMU"
+check_kernel_config "$CONFIGS" || {
+    log_fail "Device tree validation failed."


Here you are loging wrong statement. Please correct.

Updated log statement

smuppand · 2025-05-28T15:04:02Z

Runner/suites/Kernel/FunctionalArea/baseport/iommu/run.sh

+}
+LOADED_MODULES="msm_iommu arm_smmu"
+check_driver_loaded "$LOADED_MODULES" || {
+    log_fail "Device tree validation failed."


Please correct the log statement according to the modules

Updated log statement

smuppand

Few minor changes. Rest LGTM.

smuppand · 2025-05-28T15:06:06Z

Runner/suites/Kernel/FunctionalArea/DCVS/Freq_Scaling/run.sh

+
+
+check_kernel_config CONFIG_CPU_FREQ CONFIG_CPU_FREQ_GOV_SCHEDUTIL CONFIG_CPU_FREQ_GOV_PERFORMANCE
+


Add checks similar to IOMMU test.

Added the required checks

smuppand · 2025-05-28T15:06:47Z

Runner/suites/Kernel/FunctionalArea/DCVS/Freq_Scaling/run.sh

+
+check_kernel_config CONFIG_CPU_FREQ CONFIG_CPU_FREQ_GOV_SCHEDUTIL CONFIG_CPU_FREQ_GOV_PERFORMANCE
+
+CPUFREQ_PATH="/sys/devices/system/cpu/cpu0/cpufreq"


Better to check for all cpu* instead only cpu0

added logic to check for all CPUs

smuppand · 2025-05-28T15:11:05Z

Runner/suites/Kernel/FunctionalArea/Scheduler/CPU_affinity/run.sh

+    echo "$TESTNAME PASS" > "$res_file"
+else
+    log_fail "Failed to set CPU affinity"
+    echo "$TESTNAME FAIL" > "$test_path"/$TESTNAME.res


Better main consistency of logging across the scripts

updated logging

smuppand · 2025-05-28T15:11:14Z

Runner/suites/Kernel/FunctionalArea/Scheduler/CPU_affinity/run.sh

+    echo "$TESTNAME PASS" > "$res_file"
+else
+    log_fail "Unexpected scheduling policy. Test Failed"
+    echo "$TESTNAME FAIL" > "$test_path"/$TESTNAME.res


Better main consistency of logging across the scripts

updated logging

smuppand · 2025-05-28T15:13:57Z

Runner/suites/Kernel/FunctionalArea/DCVS/Freq_Scaling/README.md

@@ -0,0 +1,37 @@
+# IOMMU Validation Test
+


Test name is wrong

Updated test name

smuppand · 2025-05-28T15:14:45Z

Runner/suites/Kernel/FunctionalArea/Scheduler/CPU_affinity/README.md

@@ -0,0 +1,37 @@
+# IOMMU Validation Test


Document title it wrong, it should be scheduler instead of IOMMU

Updated title

vnarapar · 2025-05-29T02:51:24Z

@smuppand all comments fixed now

smuppand · 2025-05-29T04:00:57Z

Runner/suites/Kernel/FunctionalArea/DCVS/Freq_Scaling/run.sh

+CPUFREQ_BASE_PATH="/sys/devices/system/cpu"
+i=0
+
+while [ "$i" -le 7 ]; do


Better to make this function generic and target-agnostic. So it works on any number of cpus/cores across the platforms.

Dynamically enumerate CPUs from /sys/devices/system/cpu/ (look for cpu[0-9]* directories).

Iterate over these directories to check for cpufreq presence.

Fail only if at least one CPU should support CPUFreq but doesn't.

smuppand · 2025-05-29T04:03:55Z

Runner/suites/Kernel/FunctionalArea/DCVS/Freq_Scaling/run.sh

+log_info "CPU frequency range: $MIN_FREQ - $MAX_FREQ"
+
+log_info "Triggering frequency update via governor"
+cat /dev/urandom | head -c 1000M > /dev/null &


Its not the best or most idiomatic way to use of cat. Instead use head -c 1000M /dev/urandom > /dev/null &

Updated command with dd if=/dev/urandom of=/dev/null bs=1M count=1000 &

Runner/suites/Kernel/FunctionalArea/Scheduler/CPU_affinity/run.sh

smuppand · 2025-05-29T04:18:44Z

Runner/suites/Kernel/FunctionalArea/Scheduler/CPU_affinity/run.sh

+
+log_info "Creating a CPU-bound background task..."
+cpu_task() {
+    while :; do :; done


The loop while :; do :; done is fine for an infinite loop, but it may be more readable as while true; do :; done.

Modified as suggested

mwasilew

Last commit with common functions should be moved to be the 1st commit.

Runner/suites/Kernel/FunctionalArea/DCVS/Freq_Scaling/run.sh

Runner/suites/Kernel/FunctionalArea/baseport/iommu/run.sh

smuppand

Please rebase your feature branch on top of the latest main. This makes the PR earier to review and merge.

This commit is to add check_kernel_config function in common functions This function will check if the corresponding configs are enabled in /proc/config.gz Added check_driver_loaded to check if any driver is loaded. Added check_dt_nodes to check if DT nodes are present Signed-off-by: Vamsee Narapareddi <vnarapar@qti.qualcomm.com>

This testcase vaildates configs like CONFIG_CPU_FREQ CONFIG_CPU_FREQ_GOV_SCHEDUTIL CONFIG_CPU_FREQ_GOV_PERFORMANCE and checks cpu frequencies` before and after a load is applied Signed-off-by: Vamsee Narapareddi <vnarapar@qti.qualcomm.com>

This test validates the Scheduler support by checking corresponding SCHED configs and checks cpu affinity by creating a CPU-bound background task Signed-off-by: Vamsee Narapareddi <vnarapar@qti.qualcomm.com>

This test validates the IOMMU (Input-Output Memory Management Unit) support by checking IOMMU configs and checks if the corresponding drivers are loaded instead of just checking the dmesg logs. Signed-off-by: Vamsee Narapareddi <vnarapar@qti.qualcomm.com>

smuppand

LGTM

Need for addressing CI failures

vnarapar requested review from mwasilew and smuppand May 26, 2025 06:00

smuppand reviewed May 26, 2025

View reviewed changes

smuppand requested changes May 26, 2025

View reviewed changes

smuppand reviewed May 26, 2025

View reviewed changes

vnarapar force-pushed the main branch 4 times, most recently from f495f75 to 2322190 Compare May 28, 2025 05:24

smuppand reviewed May 28, 2025

View reviewed changes

vnarapar force-pushed the main branch 2 times, most recently from 7cdfdbe to f6f346e Compare May 28, 2025 06:45

smuppand reviewed May 28, 2025

View reviewed changes

vnarapar force-pushed the main branch 2 times, most recently from 06f8566 to 82a7c2c Compare May 28, 2025 12:25

smuppand reviewed May 28, 2025

View reviewed changes

smuppand requested changes May 28, 2025

View reviewed changes

smuppand reviewed May 28, 2025

View reviewed changes

vnarapar force-pushed the main branch from 82a7c2c to e6c44a0 Compare May 29, 2025 02:50

smuppand reviewed May 29, 2025

View reviewed changes

Runner/suites/Kernel/FunctionalArea/Scheduler/CPU_affinity/run.sh Show resolved Hide resolved

smuppand reviewed May 29, 2025

View reviewed changes

mwasilew previously requested changes May 30, 2025

View reviewed changes

Runner/suites/Kernel/FunctionalArea/DCVS/Freq_Scaling/run.sh Show resolved Hide resolved

Runner/suites/Kernel/FunctionalArea/baseport/iommu/run.sh Show resolved Hide resolved

smuppand requested changes Jun 3, 2025

View reviewed changes

vnarapar force-pushed the main branch from 75a3eb3 to d354fa5 Compare June 4, 2025 11:24

vnarapar added 4 commits June 4, 2025 16:55

Added DCVS testcase

4caff2b

This testcase vaildates configs like CONFIG_CPU_FREQ CONFIG_CPU_FREQ_GOV_SCHEDUTIL CONFIG_CPU_FREQ_GOV_PERFORMANCE and checks cpu frequencies` before and after a load is applied Signed-off-by: Vamsee Narapareddi <vnarapar@qti.qualcomm.com>

Added Scheduler testcase

7c6317c

This test validates the Scheduler support by checking corresponding SCHED configs and checks cpu affinity by creating a CPU-bound background task Signed-off-by: Vamsee Narapareddi <vnarapar@qti.qualcomm.com>

vnarapar force-pushed the main branch from d354fa5 to 7a491eb Compare June 4, 2025 11:26

smuppand approved these changes Jun 4, 2025

View reviewed changes

smuppand merged commit e39ea74 into qualcomm-linux:main Jun 4, 2025
5 of 6 checks passed



		check_kernel_config CONFIG_CPU_FREQ CONFIG_CPU_FREQ_GOV_SCHEDUTIL CONFIG_CPU_FREQ_GOV_PERFORMANCE


		check_kernel_config CONFIG_CPU_FREQ CONFIG_CPU_FREQ_GOV_SCHEDUTIL CONFIG_CPU_FREQ_GOV_PERFORMANCE

		CPUFREQ_PATH="/sys/devices/system/cpu/cpu0/cpufreq"

Added Kernel Level testcases #48

Added Kernel Level testcases #48

Uh oh!

Conversation

vnarapar commented May 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smuppand left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smuppand left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vnarapar commented May 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment