Skip to content

Add: test script for validating Qualcomm HWRNG functionality #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nklazy
Copy link

@nklazy nklazy commented May 16, 2025

Adds initial test script and supporting documentation to validate qcom_hwrng integration and functionality.

Copy link
Contributor

@mwasilew mwasilew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your signed-off-by to use first and last name.

@nklazy
Copy link
Author

nklazy commented May 27, 2025

Please update your signed-off-by to use first and last name.

@mwasilew In the latest commit, I expanded the last name and signed off, but the DCO Signed off check is failing.

Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this feature branch on top of latest main. This helps to review the PR easier and merge.

Copy link
Contributor

@mwasilew mwasilew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits

@nklazy
Copy link
Author

nklazy commented Jun 12, 2025

Rebased and Squashed all commits on this feature branch on top of latest main

Copy link
Contributor

@mwasilew mwasilew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks OK. The markdown file is missing copyright statement. Please fix the commiter email. This is what the automated checks are complaining about:

Invalid email for Committer: root@hu-naveenks-hyd.qualcomm.com

Set the email in the repository (or globally)

git config user.email your_email@address
git congig user.name "Your Name"

After that rewrite the commit

git commit --amend -s --reset-author

@nklazy
Copy link
Author

nklazy commented Jun 12, 2025

Thanks @mwasilew, Amended with changed committer email

Copy link
Contributor

@mwasilew mwasilew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Qualcomm's copyright to the .md file. I think this is the last missing bit

@nklazy
Copy link
Author

nklazy commented Jun 12, 2025

Please add Qualcomm's copyright to the .md file. I think this is the last missing bit

Done

mwasilew
mwasilew previously approved these changes Jun 12, 2025
@smuppand smuppand self-requested a review June 12, 2025 14:26
Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor changes are required.

@nklazy
Copy link
Author

nklazy commented Jun 17, 2025

Amended with changes.

@nklazy nklazy force-pushed the main branch 2 times, most recently from 6e87484 to c140375 Compare June 17, 2025 09:17
- Added initial test script to validate Qualcomm HWRNG functionality
- Refined script and documentation based on review feedback

Signed-off-by: Naveenkumar Suresh <naveenks@qti.qualcomm.com>
Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still few more changes are needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants