-
Notifications
You must be signed in to change notification settings - Fork 17
Add: test script for validating Qualcomm HWRNG functionality #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update your signed-off-by to use first and last name.
@mwasilew In the latest commit, I expanded the last name and signed off, but the DCO Signed off check is failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase this feature branch on top of latest main. This helps to review the PR easier and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the commits
Rebased and Squashed all commits on this feature branch on top of latest main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks OK. The markdown file is missing copyright statement. Please fix the commiter email. This is what the automated checks are complaining about:
Invalid email for Committer: root@hu-naveenks-hyd.qualcomm.com
Set the email in the repository (or globally)
git config user.email your_email@address
git congig user.name "Your Name"
After that rewrite the commit
git commit --amend -s --reset-author
Thanks @mwasilew, Amended with changed committer email |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add Qualcomm's copyright to the .md file. I think this is the last missing bit
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor changes are required.
Amended with changes. |
6e87484
to
c140375
Compare
Runner/suites/Kernel/FunctionalArea/baseport/qcom_hwrng/README_qcom_hwrng.md
Outdated
Show resolved
Hide resolved
Runner/suites/Kernel/FunctionalArea/baseport/qcom_hwrng/README_qcom_hwrng.md
Outdated
Show resolved
Hide resolved
Runner/suites/Kernel/FunctionalArea/baseport/qcom_hwrng/README_qcom_hwrng.md
Outdated
Show resolved
Hide resolved
- Added initial test script to validate Qualcomm HWRNG functionality - Refined script and documentation based on review feedback Signed-off-by: Naveenkumar Suresh <naveenks@qti.qualcomm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still few more changes are needed
Adds initial test script and supporting documentation to validate qcom_hwrng integration and functionality.