Add test script to validate USB Host mode #33
Conversation
|
This change looks good. I think only some docs about the setup are missing. |
|
Added README with documentation for setup |
achauras-qcom
force-pushed
the
feature/usbhost
branch
from
d00e633 to
b55d702
Compare
There was a problem hiding this comment.
Please cleanup the commit message on the squashed commit. There only needs to be one signed-off-by tag. Also most of the text in the body can be dropped as it doesn't seem applicable
These lines can be dropped:
Signed-off-by: Aanchal Chaurasia <achauras@qti.qualcomm.com>
Add SPDX license headers to USBHost/run.sh
Updates shell script under the USBHost/ directory to include proper SPDX
license identifiers and copyright:
SPDX-License-Identifier: BSD-3-Clause-Clear
This change supports automation tools like repolinter and align with open
source best practices.
Signed-off-by: Aanchal Chaurasia <achauras@qti.qualcomm.com>
Add comments regarding test setup
Include test setup information as comment in the script header. This
informs tester of hardware setup requirement before starting test.
fcb85dd to
383afde
Compare
|
|
||
| #Setup requires at least one USB peripheral connected to USB port that supports Host mode function | ||
|
|
||
| #!/bin/sh |
There was a problem hiding this comment.
Please move shebang to the first line in the script.
|
|
||
| #!/bin/sh | ||
| # Import test suite definitions | ||
| $(pwd)/init_env |
There was a problem hiding this comment.
should be
. "${PWD}"/init_env
| TESTNAME="USBHost" | ||
|
|
||
| #import test functions library | ||
| . "$(dirname "$0")/../../utils/functestlib.sh" |
There was a problem hiding this comment.
In other scripts this is imported as
. "${TOOLS}"/functestlib.sh
Maybe we should keep the same convention here.
|
Thanks for the review. Can I make these changes with a single commit message like "Update import suite/function paths" or do you suggest separate commits? |
|
@achauras-qcom update the commit "Add test script to validate USB Host mode" and force push to your fork. |
achauras-qcom
force-pushed
the
feature/usbhost
branch
from
383afde to
bac239b
Compare
| #Setup requires at least one USB peripheral connected to USB port that supports Host mode function | ||
|
|
||
| # Import test suite definitions | ||
| . $(pwd)/init_env |
There was a problem hiding this comment.
please add quotes here to prevent word splitting.
. "${PWD}"/init_env
This is the last bit before merging. The rest looks good!
The shell script verifies the enumeration of USB devices connected to DUT for testing USB Host mode functionality. Signed-off-by: Aanchal Chaurasia <achauras@qti.qualcomm.com>
Added setup information and basic requirements. This informs the tester of the hardware setup requirement before starting test. Signed-off-by: Aanchal Chaurasia <achauras@qti.qualcomm.com>
achauras-qcom
force-pushed
the
feature/usbhost
branch
from
bac239b to
fd19823
Compare
The shell script verifies the enumeration of USB devices connected to DUT for testing USB Host mode functionality.