[WIP] ci: add ShellCheck workflow for shell script linting #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwasilew
requested changes
May 15, 2025
.github/workflows/shellcheck.yml
Outdated
| run: sudo apt-get install -y shellcheck | ||
| - name: Run ShellCheck | ||
| run: | | ||
| find . -name '*.sh' -exec shellcheck {} + |
There was a problem hiding this comment.
we should probably exclude some codes. In test definitions the following codes are excluded: SC1091 SC2230 SC3043
|
I think all checks should be green. If you want to introduce shellcheck you need to either fix all warnings beforehand or in the same PR. |
smuppand
changed the title
smuppand
force-pushed
the
workflow
branch
2 times, most recently
from
18fc69e to
b6e4127
Compare
mwasilew
reviewed
May 21, 2025
smuppand
force-pushed
the
workflow
branch
2 times, most recently
from
05aaf7c to
aba7a6f
Compare
… on all shell scripts within the repository. It helps enforce shell scripting best practices and maintain consistent code quality across test suites. Key additions: - defines the CI job using latest stable ShellCheck. - Targets scripts recursively from the root. - Fails the job if any warnings or errors are detected. This integration ensures early feedback during pull requests and prevents merging poorly formatted or unsafe shell code. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
mwasilew
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves code quality and enforces consistency in shell script contributions.