Public CI Graphics GLMark2 Shell Scripts. #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwasilew
requested changes
May 14, 2025
| if ! command -v /usr/bin/glmark2-es2-wayland &> /dev/null; then | ||
| echo -e "${RED}[ERROR]${NC} glmark2-es2-wayland not found in system path." | ||
| log_fail "$TESTNAME : glmark2-es2-wayland binary not found" | ||
| echo "$TESTNAME SKIP " > "$test_path/$TESTNAME.res" |
There was a problem hiding this comment.
Please remove whitespace after SKIP
There was a problem hiding this comment.
Done, in Fresh commit.
| mkdir -p results/glmark2 | ||
| chmod -R 755 results/glmark2 | ||
|
|
||
| # Start logs |
There was a problem hiding this comment.
Are these logs used in the test (scanning for kernel warning or sth like this)? If not, please remove them.
There was a problem hiding this comment.
Yes, these are good to have logs to debug Kernel Errors and warnings
Done , in Fresh commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented shell scripts for public CI for Graphics GLMark2.
Added Graphics GLMark2 script
Added readme document for Graphics validation