Skip to content

Adding Scripts for Audio Playback and Audio Record for Public CI Testcases #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

Adding Scripts for Audio Playback and Audio Record for Public CI Testcases #25

merged 1 commit into from
May 29, 2025

Conversation

abbajaj806
Copy link
Contributor

@abbajaj806 abbajaj806 commented May 13, 2025 •
edited
Loading

Adding Scripts for Audio Playback and Audio Record for Public CI Testcases

  • Added Audio Playback Shell Script
  • Added ReadMe for Audio Playback
  • Added Audio Record Shell Script
  • Added ReadMe for Audio Record
  • Added YAML for Pre-merge LAVA plan to run AudioRecord and AudioPlayback

smuppand
smuppand reviewed May 15, 2025
View reviewed changes
smuppand
smuppand reviewed May 15, 2025
View reviewed changes
smuppand
smuppand reviewed May 15, 2025
View reviewed changes
smuppand
smuppand reviewed May 15, 2025
View reviewed changes
mwasilew
mwasilew requested changes May 15, 2025
View reviewed changes
Copy link
Contributor

@mwasilew mwasilew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this test require any special hardware setup? Connect output to input or sth similar? It's not specified in the docs.

@abbajaj806 abbajaj806 force-pushed the Audio branch 3 times, most recently from 0db2e36 to 134a106 Compare May 19, 2025 09:43
mwasilew
mwasilew requested changes May 20, 2025
View reviewed changes
Copy link
Contributor

@mwasilew mwasilew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the following format for signed-off-by
Fist Last email@address

mwasilew
mwasilew previously requested changes May 20, 2025
View reviewed changes
@abbajaj806 abbajaj806 force-pushed the Audio branch 2 times, most recently from b0deeee to 57e6d88 Compare May 23, 2025 11:20
@abbajaj806 abbajaj806 requested a review from mwasilew May 23, 2025 11:32
@abbajaj806 abbajaj806 force-pushed the Audio branch 4 times, most recently from b139dfa to 5a213e0 Compare May 23, 2025 17:25
@mwasilew
Copy link
Contributor

Video test with library functions was merged. Please rebase this PR and try it out. I think there may be an issue with paths where the files are saved.

@abbajaj806 abbajaj806 force-pushed the Audio branch 3 times, most recently from ee908d2 to 5c29321 Compare May 28, 2025 04:40
smuppand
smuppand reviewed May 28, 2025
View reviewed changes
smuppand
smuppand reviewed May 28, 2025
View reviewed changes
@abbajaj806 abbajaj806 force-pushed the Audio branch 2 times, most recently from 48ad052 to bb71f9f Compare May 28, 2025 15:30
smuppand
smuppand requested changes May 28, 2025
View reviewed changes
Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments in the Readme.md file. Rest LGTM.

@abbajaj806 abbajaj806 requested a review from smuppand May 28, 2025 19:09
smuppand
smuppand requested changes May 29, 2025
View reviewed changes
Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more minor comments on readme document. We are almost near to merge the changes.

@abbajaj806 abbajaj806 requested a review from smuppand May 29, 2025 04:37
smuppand
smuppand reviewed May 29, 2025
View reviewed changes
smuppand
smuppand previously approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abbajaj806 abbajaj806 requested a review from smuppand May 29, 2025 08:59
@abbajaj806
Copy link
Contributor Author

Video test with library functions was merged. Please rebase this PR and try it out. I think there may be an issue with paths where the files are saved.

Rebased in fresh commit

@abbajaj806 abbajaj806 dismissed mwasilew’s stale review May 29, 2025 09:04

Addressed a part of fresh commit

mwasilew
mwasilew requested changes May 29, 2025
View reviewed changes
Copy link
Contributor

@mwasilew mwasilew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from test definition which should be updated. Did you run this in LAVA?

@abbajaj806
Adding Scripts for Audio Playback and Audio Record for Public CI Test…
a653bf3 
…cases

Added Audio Playback Shell Script
Added ReadMe for Audio Playback
Added Audio Record Shell Script
Added ReadMe for Audio Record
Added YAML for Pre-merge LAVA plan to run AudioRecord and AudioPlayback

Signed-off-by: Abhishek Bajaj <abbajaj@qti.qualcomm.com>
@abbajaj806 abbajaj806 requested a review from mwasilew May 29, 2025 09:16
@smuppand smuppand merged commit 635e45b into qualcomm-linux:main May 29, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwasilew mwasilew mwasilew approved these changes

@vnarapar vnarapar Awaiting requested review from vnarapar

@SaktheeswaranSamythevarRajapandi SaktheeswaranSamythevarRajapandi Awaiting requested review from SaktheeswaranSamythevarRajapandi

@smuppand smuppand Awaiting requested review from smuppand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abbajaj806 @mwasilew @SaktheeswaranSamythevarRajapandi @smuppand