-
Notifications
You must be signed in to change notification settings - Fork 11
overlay-debs: Add linux debdiff for RB1 #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and nice job narrowing down the config changes to such a small list :)
Ideally we'd confirm this is booting and passing tests, but I'm unclear on what's needed for that (still absorbing the various defined workflows). I do understand it won't change any builds in itself though, so feel free to land when appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow comments
I pushed a new version, but:
I'm trying a build reverting the changes for the above, and will see if it's enough |
I pushed my current build attempt, but I haven't finished building + testing this |
Doesn't boot |
Ok, this latest one does boot and seems decent in config changes |
This is the actual diff between the generated configs for experimental and debs resulting from my latest debdiff:
|
This latest one does NOT boot; here's the full config diff:
|
Latest debdiff does NOT boot, so perhaps can remain a module, but CONFIG_RPMSG_QCOM_SMD=y is needed |
Latest attempt fails to boot, but in a creative new way:
|
Ok, this was a one-off; I rebooted 3 times successfully with the same kernel. |
Here's a full config diff between Debian experimental and latest booting debdiff:
|
This turns on a number of configs to enable RB1 with Debian kernels. Signed-off-by: Loïc Minier <loic.minier@oss.qualcomm.com>
Latest debdiff boots, is ready to send to Debian, and for merging here; this is the actual config diff:
|
LGTM now, thanks a lot for all the debugging efforts! |
thanks for the reviews and guidance! |
This turns on a number of configs, more than needed, to fix RB1 boot
with Debian kernels.
The changelog doesn't use experimental because that requires using "exp"
in the version number.