Skip to content

Add mesa snapshot overlay #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+1,135 −2
Open

Add mesa snapshot overlay #72

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
818f7a0
scripts/build-deb: support preparing sources via the script
lumag Jun 12, 2025
4f2aafc
overlay-debs: add Mesa snapshot
lumag Jun 12, 2025
53e17b8
overlay-debs/mesa-snapshot: import patchset implementing RGB888 support
lumag Jun 12, 2025
87c1132
overlay-debs/mesa-snapshot: pull in FP16 fixes
lumag Jun 23, 2025
ca86dfe
overlay-debs/mesa-snapshot: enable relevant OpenCL drivers by default
lumag Jun 23, 2025
ba0c2a3
overlay-debs/mesa-snapshot: use qcom-specific version
lumag Jun 23, 2025
76162c8
mesa-snapshot.sh: quote shell variables
basak-qcom Jun 25, 2025
801a273
mesa-snapshot.sh: ignore shellcheck false positive
basak-qcom Jun 25, 2025
37bd828
mesa-snapshot: add README.md delta description
basak-qcom Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions overlay-debs/mesa-snapshot/mesa-snapshot.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,26 +8,26 @@ COMMIT=${COMMIT:-origin/main}
set -e

DEB_FILE=${DSC_FILE%%.dsc}.debian.tar.xz
ORIG_FILE=$(echo ${DSC_FILE} | sed -e 's/-.*/.orig.tar.xz/')
ORIG_FILE=$(echo "${DSC_FILE}" | sed -e 's/-.*/.orig.tar.xz/')

rm -rf mesa
git clone --depth 1 https://gitlab.freedesktop.org/mesa/mesa

cd mesa
git fetch --depth 1 origin ${COMMIT##origin/}
git fetch --depth 1 origin "${COMMIT##origin/}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to quote all the variables. Only the variables that might have whitespaces or might be empty need to be quoted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, shellcheck doesn't know that, so it asks to quote everything by default, but we can add an override to tell it to ignore this particular line; I think it's cheaper to add the double quotes personally, even if it's a bit more verbose

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my general comment on lint tools and CI. The compromise is that even though it's not necessary, it's not wrong, so this is fine as-is. That way we can have a linter and CI, which is better for our culture overall.


date=$(git log -1 --format=%cd --date=format:%Y%m%d ${COMMIT})
subject=$(git log -1 --format="%h (\"%s\")" ${COMMIT})
date=$(git log -1 --format=%cd --date=format:%Y%m%d "${COMMIT}")
subject=$(git log -1 --format="%h (\"%s\")" "${COMMIT}")
version=25.2.0~git${date}

rm -rf ../mesa-${version}
mkdir ../mesa-${version}
git archive --format=tar HEAD | tar x -C ../mesa-${version}
rm -rf ../mesa-"${version}"
mkdir ../mesa-"${version}"
git archive --format=tar HEAD | tar x -C ../mesa-"${version}"

cd ../mesa-${version}
cd ../mesa-"${version}"

rm -rf debian
tar xJf ${DEB_FILE}
tar xJf "${DEB_FILE}"

cat >> debian/changelog.tmp << EOF
mesa (${version}-0qcom1) experimental; urgency=medium
Expand All @@ -49,4 +49,4 @@ debian/rules gentarball

rm -rf ../mesa

rm ${DSC_FILE} ${DEB_FILE} ${ORIG_FILE}*
rm "${DSC_FILE}" "${DEB_FILE}" "${ORIG_FILE}"*
Loading