Skip to content

Conversation

vidma
Copy link
Contributor

@vidma vidma commented Jun 8, 2025

@qqqlab I been confused to many times which direction is which so made this change from what I found in ahr.h
e.g.

pahr

roll:+27.7 (roll right) pitch:-4.3 (pitch down) yaw:+52.9 (yaw right)
roll:+8.1 (roll right)  pitch:-1.3 (pitch down) yaw:+50.0 (yaw right)
roll:-6.7 (roll left)   pitch:+0.9 (pitch up)   yaw:+48.5 (yaw right)
roll:-16.8 (roll left)  pitch:+2.5 (pitch up)   yaw:+47.2 (yaw right)

so it seems we're partially following this convention (except yaw direction is inverted)?

image

@qqqlab
Copy link
Owner

qqqlab commented Jun 9, 2025

I like this, but I also like the less verbose "old" pahr...

Let's have both: rename the current pahr to pah (?) and add the new pahr. The docs refers to pahr, so new users get steered to the verbose version.

What do you think?

I've updated the AHRS documentation to explain the used local body frame (which is local NED).

@vidma vidma force-pushed the human-friendly-pahr branch from 693bd29 to afc28d2 Compare June 15, 2025 10:34
@vidma
Copy link
Contributor Author

vidma commented Jun 15, 2025

@qqqlab updated

@qqqlab qqqlab merged commit 17c1b62 into qqqlab:main Jul 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants