-
Notifications
You must be signed in to change notification settings - Fork 358
Update serialising methods and instructions #951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update serialising methods and instructions #951
Conversation
Pull Request Test Coverage Report for Build 15610565253Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Needs a reno release note to cover the deprecation of save/load and these new replacement methods.
I get that the improved example may well go towards solving the referenced issue. Its just less clear to me how changing the names of the methods helps in that regard. I guess if one cares it makes it clear that its saved as a dill file, otherwise, while names can be changed maybe I am missing something.
The main motivation is to make it clear in which format the io is done, and partially also staying consistent with the syntax used in other libs like pandas, where |
releasenotes/notes/serializable-model-update-io-b708094e41edeb35.yaml
Outdated
Show resolved
Hide resolved
Also should not this tutorial |
Summary
Mark the legacy save/load methods as deprecated (v0.9.0) and point users to to_dill/from_dill.
Add short usage examples under each serialisation method.
Clarify raised exceptions in argument docs.
Details and comments
Closes #891