Fix for issue #911 (backport #926) #939
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Internally the subclass of trainable kernel would call its super init where BaseKernel would create a default feature_map, if none was passed, so that the feature_map attribute afterwards was a valid feature_map. Now the derived classes, in places used feature_map instead of self.feature_map where the former was still None. This changes the code to use self.feature_map and added tests to ensure construction is successful.
closes #911
Details and comments
This is an automatic backport of pull request #926 done by [Mergify](https://mergify.com).