Skip to content

Fix for issue #911 (backport #926) #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 22, 2025

Summary

Internally the subclass of trainable kernel would call its super init where BaseKernel would create a default feature_map, if none was passed, so that the feature_map attribute afterwards was a valid feature_map. Now the derived classes, in places used feature_map instead of self.feature_map where the former was still None. This changes the code to use self.feature_map and added tests to ensure construction is successful.

closes #911

Details and comments


This is an automatic backport of pull request #926 done by [Mergify](https://mergify.com).

(cherry picked from commit 2ecf056)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15194876158

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.637%

Totals Coverage Status
Change from base Build 15194846110: 0.0%
Covered Lines: 4366
Relevant Lines: 4817

💛 - Coveralls

@edoaltamura edoaltamura merged commit 93140ba into stable/0.8 May 22, 2025
15 checks passed
@edoaltamura edoaltamura deleted the mergify/bp/stable/0.8/pr-926 branch May 22, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants