Skip to content

Q2 kmerizer #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2025
Merged

Q2 kmerizer #18

merged 3 commits into from
Mar 19, 2025

Conversation

Oddant1
Copy link
Member

@Oddant1 Oddant1 commented Mar 18, 2025

Get the action to run again on this

@Oddant1
Copy link
Member Author

Oddant1 commented Mar 18, 2025

@VinzentRisch I opened this PR so I would be able to manually re-run the linting action on the changes in your PR, but I can't actually run that action right now because we aren't allowing any 3rd party github actions (some of which the linter depends on) to run on the org right now (long story). Should this be ready to merge though? Once I actually can lint it and verify it passes?

@VinzentRisch
Copy link
Contributor

Hey @Oddant1
Yes this is ready to merge I think. I did all the needed changes in the plugin for it to be added.

@Oddant1
Copy link
Member Author

Oddant1 commented Mar 19, 2025

This passed lint, so I am merging this and closing #16 and merging this so we have record of the merged PR passing lint. It's the same commit

Oh cool GitHub was actually smart enough to realize it was the same exact PR and marked the other one merged too. Neat.

@Oddant1 Oddant1 merged commit fff3729 into main Mar 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants