Skip to content

Refactor radio check function to simplify logic and use configuration… #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 13, 2025
Merged

Refactor radio check function to simplify logic and use configuration… #60

merged 4 commits into from
Feb 13, 2025

Conversation

@Cocodrulo
Copy link
Contributor

@Cocodrulo Cocodrulo commented Jan 15, 2025 •
edited
Loading

Describe Pull request
Simply change the DoRadioCheck logic to use the QBCore.Functions.HasItem(items, quant).

If your PR is to fix an issue mention that issue here

Questions (please complete the following information):

  • Have you personally loaded this code into an updated qbcore project and checked all it's functionality? [no]
  • Does your code fit the style guidelines? [yes]
  • Does your PR fit the contribution guidelines? [yes]

@GhzGarage GhzGarage merged commit e725307 into qbcore-framework:main Feb 13, 2025
2 checks passed
@Cocodrulo Cocodrulo deleted the refactor/hasitem branch February 13, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qwerty1Verified Qwerty1Verified Qwerty1Verified approved these changes

+1 more reviewer

@mbiddle mbiddle mbiddle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Cocodrulo Cocodrulo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Cocodrulo @mbiddle @Qwerty1Verified @GhzGarage