Mechomancer patch 1 #526
Merged
Mechomancer patch 1 #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was added to check the drop for items if no items this removes the bag drop from the world Adding more code on client side so your unable to pick up more than one drop at a time. Avoids getting a drop with or without items stuck to you by picking up another.
This was added as part of the multi drop holding conundrum and to ensure there can only be one drop held at a time by the player. When drop has no items it's deleted this also removes the target on the bag before it's deleted.
Update drops.lua
GhzGarage
reviewed
May 29, 2024
server/main.lua
Outdated
| @@ -159,6 +159,13 @@ RegisterNetEvent('qb-inventory:server:closeInventory', function(inventory) | |||
| end | |||
| if Drops[inventory] then | |||
| Drops[inventory].isOpen = false | |||
| if #Drops[inventory].items == 0 and not Drops[inventory].isOpen then -- if no listeed items in the drop on close | |||
| TriggerClientEvent('qb-inventory:client:removeDropTarget', Drops[inventory].entityId) | |||
There was a problem hiding this comment.
What client is this triggering on?
added source or -1 to the client call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a multiple drops issue i discovered as it never deletes the drop when empty. this allows you to also pick up an empty drop and then another leaving the first one stuck to the player. So now it also catches if your already carrying a bag you can not pick up another one till you drop the current one.
Checklist