-
Notifications
You must be signed in to change notification settings - Fork 515
Disable running slow CI for doc-only changes #9072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Okay I've done some testing on my fork. It should trigger the workflows when there are code changes. If PR only has markdown changes, it should return success early and skip running the actual tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ghpvnist still not works:
|
4b0be6b
to
659675c
Compare
@ghpvnist could you try rebasing? looks like there are still test failures |
I did rebase this ~2 hrs ago. @tengyifei Does |
While getting #9065 reviewed, I noticed that we're running expensive (and long) CI even for no-op changes like removing trailing whitespaces from markdown files.
Note that this only skips CI when the entire PR only consists of markdown changes. Removing the CI for comments are more difficult. However, this is a step in the right direction to save some resources and enable merging PRs faster.
fixes #9073