Added support for column_wise benchmark in enumerator benchmark #3230
+291
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78856316 |
aliafzal
force-pushed
the
export-D78856316
branch
from
e5bab74 to
10a6a73
Compare
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Jul 24, 2025
…rch#3230) Summary: Added option to include column_wise enumerator benchmark Differential Revision: D78856316
|
This pull request was exported from Phabricator. Differential Revision: D78856316 |
aliafzal
force-pushed
the
export-D78856316
branch
from
10a6a73 to
e91d9aa
Compare
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Jul 24, 2025
…rch#3230) Summary: Added option to include column_wise enumerator benchmark Reviewed By: SSYernar Differential Revision: D78856316
|
This pull request was exported from Phabricator. Differential Revision: D78856316 |
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Jul 24, 2025
…rch#3230) Summary: Added option to include column_wise enumerator benchmark Reviewed By: SSYernar Differential Revision: D78856316
aliafzal
force-pushed
the
export-D78856316
branch
from
e91d9aa to
a46e819
Compare
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Jul 25, 2025
…rch#3230) Summary: Added option to include column_wise enumerator benchmark Reviewed By: SSYernar Differential Revision: D78856316
|
This pull request was exported from Phabricator. Differential Revision: D78856316 |
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Jul 25, 2025
…rch#3230) Summary: Added option to include column_wise enumerator benchmark Reviewed By: SSYernar Differential Revision: D78856316
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Jul 25, 2025
…rch#3230) Summary: Added option to include column_wise enumerator benchmark Reviewed By: SSYernar Differential Revision: D78856316
Summary: Pull Request resolved: pytorch#3229 1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400). 2. Added sharder type options, millisecond timing, and memory tracking. Differential Revision: D78855814 Reviewed By: SSYernar
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Jul 25, 2025
…rch#3230) Summary: Added option to include column_wise enumerator benchmark Reviewed By: SSYernar Differential Revision: D78856316
aliafzal
force-pushed
the
export-D78856316
branch
from
a46e819 to
52fbcca
Compare
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Jul 25, 2025
…rch#3230) Summary: Added option to include column_wise enumerator benchmark Reviewed By: SSYernar Differential Revision: D78856316
aliafzal
force-pushed
the
export-D78856316
branch
from
52fbcca to
373b5a7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78856316 |
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Jul 25, 2025
…rch#3230) Summary: Added option to include column_wise enumerator benchmark Reviewed By: SSYernar Differential Revision: D78856316
…rch#3230) Summary: Pull Request resolved: pytorch#3230 Added option to include column_wise enumerator benchmark Reviewed By: SSYernar Differential Revision: D78856316
|
This pull request was exported from Phabricator. Differential Revision: D78856316 |
aliafzal
force-pushed
the
export-D78856316
branch
from
373b5a7 to
f833b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Added option to include column_wise enumerator benchmark
Differential Revision: D78856316