Skip to content

Enumerator benchmark enhancement #3229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aliafzal
Copy link
Contributor

Summary:

  1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400).

  2. Added sharder type options, millisecond timing, and memory tracking.

Differential Revision: D78855814

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 24, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78855814

aliafzal added a commit to aliafzal/torchrec that referenced this pull request Jul 24, 2025
Summary:

1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400).

2. Added sharder type options, millisecond timing, and memory tracking.

Differential Revision: D78855814
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78855814

aliafzal added a commit to aliafzal/torchrec that referenced this pull request Jul 24, 2025
Summary:

1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400).

2. Added sharder type options, millisecond timing, and memory tracking.

Reviewed By: SSYernar

Differential Revision: D78855814
@aliafzal aliafzal force-pushed the export-D78855814 branch 2 times, most recently from 2b6241a to b272a0e Compare July 24, 2025 10:09
aliafzal added a commit to aliafzal/torchrec that referenced this pull request Jul 24, 2025
Summary:

1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400).

2. Added sharder type options, millisecond timing, and memory tracking.

Reviewed By: SSYernar

Differential Revision: D78855814
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78855814

aliafzal added a commit to aliafzal/torchrec that referenced this pull request Jul 24, 2025
Summary:

1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400).

2. Added sharder type options, millisecond timing, and memory tracking.

Reviewed By: SSYernar

Differential Revision: D78855814
aliafzal added a commit to aliafzal/torchrec that referenced this pull request Jul 24, 2025
Summary:

1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400).

2. Added sharder type options, millisecond timing, and memory tracking.

Reviewed By: SSYernar

Differential Revision: D78855814
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78855814

aliafzal added a commit to aliafzal/torchrec that referenced this pull request Jul 24, 2025
Summary:
Pull Request resolved: pytorch#3229

1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400).

2. Added sharder type options, millisecond timing, and memory tracking.

Reviewed By: SSYernar

Differential Revision: D78855814
@aliafzal aliafzal force-pushed the export-D78855814 branch 2 times, most recently from acc5aeb to 8e6db1c Compare July 25, 2025 09:51
aliafzal added a commit to aliafzal/torchrec that referenced this pull request Jul 25, 2025
Summary:

1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400).

2. Added sharder type options, millisecond timing, and memory tracking.

Reviewed By: SSYernar

Differential Revision: D78855814
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78855814

aliafzal added a commit to aliafzal/torchrec that referenced this pull request Jul 25, 2025
Summary:

1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400).

2. Added sharder type options, millisecond timing, and memory tracking.

Reviewed By: SSYernar

Differential Revision: D78855814
aliafzal added a commit to aliafzal/torchrec that referenced this pull request Jul 25, 2025
Summary:

1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400).

2. Added sharder type options, millisecond timing, and memory tracking.

Reviewed By: SSYernar

Differential Revision: D78855814
aliafzal added a commit to aliafzal/torchrec that referenced this pull request Jul 25, 2025
Summary:

1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400).

2. Added sharder type options, millisecond timing, and memory tracking.

Reviewed By: SSYernar

Differential Revision: D78855814
aliafzal pushed a commit to aliafzal/torchrec that referenced this pull request Jul 25, 2025
Summary:
Pull Request resolved: pytorch#3229

1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400).

2. Added sharder type options, millisecond timing, and memory tracking.

Differential Revision: D78855814

Reviewed By: SSYernar
Summary:

1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400).

2. Added sharder type options, millisecond timing, and memory tracking.

Reviewed By: SSYernar

Differential Revision: D78855814
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78855814

aliafzal added a commit to aliafzal/torchrec that referenced this pull request Jul 25, 2025
Summary:

1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400).

2. Added sharder type options, millisecond timing, and memory tracking.

Reviewed By: SSYernar

Differential Revision: D78855814
aliafzal added a commit to aliafzal/torchrec that referenced this pull request Jul 25, 2025
Summary:

1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400).

2. Added sharder type options, millisecond timing, and memory tracking.

Reviewed By: SSYernar

Differential Revision: D78855814
aliafzal added a commit to aliafzal/torchrec that referenced this pull request Jul 25, 2025
Summary:

1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400).

2. Added sharder type options, millisecond timing, and memory tracking.

Reviewed By: SSYernar

Differential Revision: D78855814
aliafzal pushed a commit to aliafzal/torchrec that referenced this pull request Jul 25, 2025
Summary:
Pull Request resolved: pytorch#3229

1. Rewrote enumerator benchmark from unittest to standalone script with comprehensive matrix testing (world sizes 16-2048 × tables 200-6400).

2. Added sharder type options, millisecond timing, and memory tracking.

Differential Revision: D78855814

Reviewed By: SSYernar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants