Add reference to policy with state dict #3043
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
_policy_w_state_dict
attribute for theSyncDataCollector
. The point here is to use this reference to do all saving/loading of the policy state dict. This fixes the bug of not being able to load/save policies that have been compiled/CudaGraph'ed.Motivation and Context
Policy models are often saved and loaded via the SyncDataCollector class, which also handles compiling and CudaGraphing the policy. However, this wraps the policy in a few layers that obscures the saving and loading of the policy weights if we attempt the access the policy directly from the
SyncDataCollector.policy
attribute.The clean solution here is to keep a reference to the unwrapped, original policy object that contains the
state_dict
and perform all model saving/loading via this reference. This way, we don't care about the method in which the object gets wrapped. This all works because every wrapped layer still points to the same underlying set of model weights.Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!