[BE] Update vllm-benchmark parameter descriptions #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est checks Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
huydhn
changed the title
Signed-off-by: Huy Do <huydhn@gmail.com>
seemethere
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small documentation change to explain how to set these parameters in different use cases.
main,vllm_branchcan be set to the release branch, i.e.release/v0.9.2or the pull request in the formatrefs/pull/PR_NUMBER/head. The latter works with both fork and non-fork PRs.vllm_commitis not set, it will be default to the latest commit in the branch that has not yet been benchmarked.vllm-benchmarks/benchmarks. Setting the wrong model name wouldn't run anything..github/scripts/generate_vllm_benchmark_matrix.py. Again, an invalid runner that is not there wouldn't do anything.Testing