Skip to content

fix pybind11 errors in cuda extension example #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

fix pybind11 errors in cuda extension example #113

merged 1 commit into from
Jun 13, 2025

Conversation

ZhaoqiongZ
Copy link
Contributor

Fix #112

dvrogozh
dvrogozh approved these changes Jun 9, 2025
View reviewed changes
Copy link

@dvrogozh dvrogozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we know whom we need to ask to review/merge on maintainers side?

@ZhaoqiongZ
Copy link
Contributor Author

Hi @dvrogozh , maybe maintainers of this repo?
Hi @zou3519 , could you please help review this fix?

@zou3519 zou3519 requested a review from janeyx99 June 12, 2025 13:40
janeyx99
janeyx99 approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks fine to me, I haven’t yet verified locally but as the PR author is the issue opener I believe you already did?

@ZhaoqiongZ
Copy link
Contributor Author

Hi @janeyx99 , yes I've verified locally!

@janeyx99 janeyx99 merged commit 11e8b30 into pytorch:master Jun 13, 2025
3 checks passed
@janeyx99
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvrogozh dvrogozh dvrogozh approved these changes

@janeyx99 janeyx99 janeyx99 approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Build Error due to py_limited_api True] error: identifier "Py_buffer" is undefined/
4 participants
@ZhaoqiongZ @janeyx99 @dvrogozh @facebook-github-bot