-
Notifications
You must be signed in to change notification settings - Fork 689
[ET-VK] Replace uint16_t
with int
for swiftshader
#6781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As title. This is a follow up from #6675. Replace `uint16_t` with `int` as well as 16 bit vectorized types. Differential Revision: [D65824204](https://our.internmc.facebook.com/intern/diff/D65824204/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6781
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit d8a714f with merge base dc41596 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
SS-JIA
added a commit
that referenced
this pull request
Nov 12, 2024
As title. This is a follow up from #6675. Replace `uint16_t` with `int` as well as 16 bit vectorized types. Differential Revision: [D65824204](https://our.internmc.facebook.com/intern/diff/D65824204/) ghstack-source-id: 253112193 Pull Request resolved: #6781
This pull request was exported from Phabricator. Differential Revision: D65824204 |
yipjustin
approved these changes
Nov 12, 2024
trivedivivek
approved these changes
Nov 12, 2024
ba68e6f
into
gh/SS-JIA/142/base
39 of 41 checks passed
SS-JIA
added a commit
that referenced
this pull request
Nov 12, 2024
As title. This is a follow up from #6675. Replace `uint16_t` with `int` as well as 16 bit vectorized types. Differential Revision: [D65824204](https://our.internmc.facebook.com/intern/diff/D65824204/) ghstack-source-id: 253112193 Pull Request resolved: #6781 Co-authored-by: Stephen Jia <ssjia@meta.com>
nathanaelsee
added a commit
to nathanaelsee/executorch
that referenced
this pull request
Nov 14, 2024
Summary: After pytorch#6781 the 8-bit linear shader can run on swiftshader. Differential Revision: D65951046
nathanaelsee
added a commit
to nathanaelsee/executorch
that referenced
this pull request
Nov 18, 2024
Summary: After pytorch#6781 the 8-bit linear shader can run on swiftshader. Reviewed By: jorgep31415 Differential Revision: D65951046
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
uint16_t
withint
for swiftshader #6781As title. This is a follow up from #6675. Replace
uint16_t
withint
as well as 16 bit vectorized types.Differential Revision: D65824204