[ET-VK] Reduced int precision for texture coordinates in conv2d_pw op, to reduce shader register pressure and slightly improve performance. #6764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, to reduce shader register pressure and slightly improve performance. This diff reduces the precision of texture coordinates in the conv2d_pw op in Executorch Vulkan backend to reduce shader register pressure. Differential Revision: [D64766910](https://our.internmc.facebook.com/intern/diff/D64766910/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6764
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4a1fcb2 with merge base 793f17e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64766910 |
This was referenced Nov 11, 2024
SS-JIA
approved these changes
Nov 11, 2024
facebook-github-bot
merged commit 3e174c2
into
gh/trivedivivek/10/base
40 of 41 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
SS-JIA
pushed a commit
that referenced
this pull request
Nov 12, 2024
…, to reduce shader register pressure and slightly improve performance. (#6774) This diff reduces the precision of texture coordinates in the conv2d_pw op in Executorch Vulkan backend to reduce shader register pressure. Differential Revision: [D64766910](https://our.internmc.facebook.com/intern/diff/D64766910/) ghstack-source-id: 252923518 Pull Request resolved: #6764 Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff reduces the precision of texture coordinates in the conv2d_pw op in Executorch Vulkan backend to reduce shader register pressure.
Differential Revision: D64766910