Skip to content

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Nov 5, 2024

Stack from ghstack (oldest at bottom):

Step 0 for code sharing: can we use c10 Macros?

This needs a guardrail to prevent breaking the ExecuTorch core
requirements before we can ship it. What's our current guard against
accidentally including streams/heap allocation/etc. in core at runtime?

Differential Revision: D65241695

Step 0 for code sharing: can we use c10 Macros?

This needs a guardrail to prevent breaking the ExecuTorch core
requirements before we can ship it. What's our current guard against
accidentally including streams/heap allocation/etc. in core at runtime?

Differential Revision: [D65241695](https://our.internmc.facebook.com/intern/diff/D65241695/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Nov 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6665

Note: Links to docs will display an error until the docs builds have been completed.

❌ 30 New Failures

As of commit 7115abe with merge base 09cf982 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 5, 2024
swolchok added a commit that referenced this pull request Nov 5, 2024
Step 0 for code sharing: can we use c10 Macros?

This needs a guardrail to prevent breaking the ExecuTorch core
requirements before we can ship it. What's our current guard against
accidentally including streams/heap allocation/etc. in core at runtime?

Differential Revision: [D65241695](https://our.internmc.facebook.com/intern/diff/D65241695/)

ghstack-source-id: 251930153
Pull Request resolved: #6665
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65241695

Step 0 for code sharing: can we use c10 Macros?

This needs a guardrail to prevent breaking the ExecuTorch core
requirements before we can ship it. What's our current guard against
accidentally including streams/heap allocation/etc. in core at runtime?

Differential Revision: [D65241695](https://our.internmc.facebook.com/intern/diff/D65241695/)

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Nov 6, 2024
Pull Request resolved: #6665

Step 0 for code sharing: can we use c10 Macros?

This needs a guardrail to prevent breaking the ExecuTorch core
requirements before we can ship it. What's our current guard against
accidentally including streams/heap allocation/etc. in core at runtime?

Differential Revision: [D65241695](https://our.internmc.facebook.com/intern/diff/D65241695/)
ghstack-source-id: 252102877
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65241695

@swolchok
Copy link
Contributor Author

we'll focus on kernel code sharing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants