[ET-VK] Fix op benchmarks code generation #6527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context As title. There was a small error in the operator benchmark code generation which impacted operators which return a collection of tensors (e.g. layer norm). The issue was that the generated code would store the output `ValueRefs` in variables that shadowed class variables of the benchmark. Differential Revision: [D65071024](https://our.internmc.facebook.com/intern/diff/D65071024/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6527
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 791cbfc with merge base 9890c24 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65071024 |
SS-JIA
added a commit
that referenced
this pull request
Oct 28, 2024
## Context As title. There was a small error in the operator benchmark code generation which impacted operators which return a collection of tensors (e.g. layer norm). The issue was that the generated code would store the output `ValueRefs` in variables that shadowed class variables of the benchmark. Differential Revision: [D65071024](https://our.internmc.facebook.com/intern/diff/D65071024/) ghstack-source-id: 250448840 Pull Request resolved: #6527
junpi3
approved these changes
Oct 28, 2024
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
SS-JIA
added a commit
that referenced
this pull request
Oct 28, 2024
## Context As title. There was a small error in the operator benchmark code generation which impacted operators which return a collection of tensors (e.g. layer norm). The issue was that the generated code would store the output `ValueRefs` in variables that shadowed class variables of the benchmark. Differential Revision: [D65071024](https://our.internmc.facebook.com/intern/diff/D65071024/) ghstack-source-id: 250448840 Pull Request resolved: #6527 Co-authored-by: Stephen Jia <ssjia@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
As title. There was a small error in the operator benchmark code generation which impacted operators which return a collection of tensors (e.g. layer norm). The issue was that the generated code would store the output
ValueRefsin variables that shadowed class variables of the benchmark.Differential Revision: D65071024