[Executorch] optimized sigmoid #6522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facebook-github-bot merged 26 commits into gh/kimishpatel/129/base from gh/kimishpatel/129/head

Nov 18, 2024

Contributor

kimishpatel commented Oct 28, 2024 •

edited

Loading

Stack from ghstack (oldest at bottom):

-> [Executorch] optimized sigmoid #6522

basically use exp approximation using sleef instead of std::exp

Differential Revision: D64156864


          [Executorch] optimized sigmoid

762f0aa

basically use exp approximation using sleef instead of std::exp

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

[ghstack-poisoned]

pytorch-bot bot commented Oct 28, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6522

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 5ea00e9 with merge base 793a988 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Oct 28, 2024

This pull request was exported from Phabricator. Differential Revision: D64156864

facebook-github-bot added the fb-exported label

This was referenced Oct 28, 2024

[Executorch][Kernels] Build optimized lib with -O2 #6517

Merged

[Executorch][llm] Compile custom op with -O2 #6518

Merged

[Executorch][Portable] Compile portable ops with -O2 #6519

Merged

[Executorch] mul broadcast update #6520

Merged

[Executorch] Handle broadcast semantics for last dim #6521

Merged

[Executorch] Make apple take accelerate path for blas #6523

Merged

[Executorch] enable sleef consistently #6524

Merged


          Update on "[Executorch] optimized sigmoid"

b20c519

basically use exp approximation using sleef instead of std::exp

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Oct 28, 2024

This pull request was exported from Phabricator. Differential Revision: D64156864


          Update on "[Executorch] optimized sigmoid"

92f9c26

basically use exp approximation using sleef instead of std::exp

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Oct 28, 2024

This pull request was exported from Phabricator. Differential Revision: D64156864


          Update on "[Executorch] optimized sigmoid"

d7271b5

basically use exp approximation using sleef instead of std::exp

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Oct 29, 2024

This pull request was exported from Phabricator. Differential Revision: D64156864


          Update on "[Executorch] optimized sigmoid"

0217dab

basically use exp approximation using sleef instead of std::exp

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Oct 29, 2024

This pull request was exported from Phabricator. Differential Revision: D64156864


          Update on "[Executorch] optimized sigmoid"

64a4245

basically use exp approximation using sleef instead of std::exp

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Oct 29, 2024

This pull request was exported from Phabricator. Differential Revision: D64156864


          Update on "[Executorch] optimized sigmoid"

9af78a2

basically use exp approximation using sleef instead of std::exp

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Oct 30, 2024

This pull request was exported from Phabricator. Differential Revision: D64156864

kimishpatel added a commit that referenced this pull request


          [Executorch] optimized sigmoid

35ff52c

Pull Request resolved: #6522

basically use exp approximation using sleef instead of std::exp
ghstack-source-id: 250845762
@exported-using-ghexport

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)


          Update on "[Executorch] optimized sigmoid"

ad03b35

basically use exp approximation using sleef instead of std::exp

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Oct 30, 2024

This pull request was exported from Phabricator. Differential Revision: D64156864

kimishpatel added a commit that referenced this pull request


          [Executorch] optimized sigmoid

60e4cbd

Pull Request resolved: #6522

basically use exp approximation using sleef instead of std::exp
ghstack-source-id: 250898891
@exported-using-ghexport

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)


          Update on "[Executorch] optimized sigmoid"

3acab31

basically use exp approximation using sleef instead of std::exp

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Oct 30, 2024

This pull request was exported from Phabricator. Differential Revision: D64156864

kimishpatel added a commit that referenced this pull request


          [Executorch] optimized sigmoid

28dca8a

Pull Request resolved: #6522

basically use exp approximation using sleef instead of std::exp
ghstack-source-id: 251666401
@exported-using-ghexport

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

Contributor

facebook-github-bot commented Nov 4, 2024

This pull request was exported from Phabricator. Differential Revision: D64156864


          Update on "[Executorch] optimized sigmoid"

f944b2f

basically use exp approximation using sleef instead of std::exp

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Nov 5, 2024

This pull request was exported from Phabricator. Differential Revision: D64156864

kimishpatel added a commit that referenced this pull request


          [Executorch] optimized sigmoid

c682c95

Pull Request resolved: #6522

basically use exp approximation using sleef instead of std::exp
ghstack-source-id: 251897406
@exported-using-ghexport

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)


          Update on "[Executorch] optimized sigmoid"

7f406c6

basically use exp approximation using sleef instead of std::exp

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          [Executorch] optimized sigmoid

0e8111c

Pull Request resolved: #6522

basically use exp approximation using sleef instead of std::exp
ghstack-source-id: 251951604
@exported-using-ghexport

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

Contributor

facebook-github-bot commented Nov 5, 2024

This pull request was exported from Phabricator. Differential Revision: D64156864


          Update on "[Executorch] optimized sigmoid"

3bd2839

basically use exp approximation using sleef instead of std::exp

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Nov 6, 2024

This pull request was exported from Phabricator. Differential Revision: D64156864

kimishpatel added a commit that referenced this pull request


          [Executorch] optimized sigmoid

0042bd0

Pull Request resolved: #6522

basically use exp approximation using sleef instead of std::exp
ghstack-source-id: 252186436
@exported-using-ghexport

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)


          Update on "[Executorch] optimized sigmoid"

110d5e4

basically use exp approximation using sleef instead of std::exp

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          [Executorch] optimized sigmoid

88c751c

Pull Request resolved: #6522

basically use exp approximation using sleef instead of std::exp
ghstack-source-id: 252985020
@exported-using-ghexport

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

Contributor

facebook-github-bot commented Nov 11, 2024

This pull request was exported from Phabricator. Differential Revision: D64156864


          Update on "[Executorch] optimized sigmoid"

1ae4748

basically use exp approximation using sleef instead of std::exp

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          [Executorch] optimized sigmoid

06f9dc6

Pull Request resolved: #6522

basically use exp approximation using sleef instead of std::exp
ghstack-source-id: 253213339
@exported-using-ghexport

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

Contributor

facebook-github-bot commented Nov 12, 2024

This pull request was exported from Phabricator. Differential Revision: D64156864


          Update on "[Executorch] optimized sigmoid"

946e71b

basically use exp approximation using sleef instead of std::exp

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          [Executorch] optimized sigmoid

43e2295

Pull Request resolved: #6522

basically use exp approximation using sleef instead of std::exp
ghstack-source-id: 253265605
@exported-using-ghexport

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

Contributor

facebook-github-bot commented Nov 13, 2024

This pull request was exported from Phabricator. Differential Revision: D64156864


          Update on "[Executorch] optimized sigmoid"

5ea00e9

basically use exp approximation using sleef instead of std::exp

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          [Executorch] optimized sigmoid

Pull Request resolved: #6522

basically use exp approximation using sleef instead of std::exp
ghstack-source-id: 254026289
@exported-using-ghexport

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

Contributor

facebook-github-bot commented Nov 17, 2024

This pull request was exported from Phabricator. Differential Revision: D64156864

facebook-github-bot merged commit a1ebbf2 into gh/kimishpatel/129/base

39 of 41 checks passed

facebook-github-bot deleted the gh/kimishpatel/129/head branch

November 18, 2024 02:09

facebook-github-bot had a problem deploying to cherry-pick-bot

November 18, 2024 02:09

— with

GitHub Actions Failure

kirklandsign mentioned this pull request

[Executorch] optimized sigmoid #6932

Merged

kirklandsign added a commit that referenced this pull request


          [Executorch] optimized sigmoid

5b4d9bb

Pull Request resolved: #6522

basically use exp approximation using sleef instead of std::exp
ghstack-source-id: 254026289
@exported-using-ghexport

Differential Revision: [D64156864](https://our.internmc.facebook.com/intern/diff/D64156864/)

Co-authored-by: Kimish Patel <kimishpatel@fb.com>

facebook-github-bot temporarily deployed to cherry-pick-bot

November 18, 2024 18:11

— with

GitHub Actions Inactive

swolchok mentioned this pull request

macOS nightly wheel builds failing since 2024-11-19 #7019

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported