The padding of concat is not needed anymore if the inputs are equal.

[jirioc]

Summary

The padding of concat is not needed anymore if the inputs are equal. This removes the necessity to use custom_delegation_options.force_delegate_cat if the model contains concat of equal sizes. This requires a support from the converter.

Test plan

The test was done using an external model.

cc @robert-kalmar @JakeStevens @digantdesai

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15102

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 2 Unrelated Failures

As of commit 33f971f with merge base 57a7903 ():

NEW FAILURES - The following jobs have failed:

• pull / test-samsung-models-linux / linux-job (gh)
  RuntimeError: Command docker exec -t ae19fa4162a165a86a07800496e49be4e6c85f3d5b38aee773f55fbd5d602c59 /exec failed with exit code 1
• Test CUDA Builds / export-voxtral-cuda-artifact / linux-job (gh)
  RuntimeError: Command docker exec -t c44cf5715d89f0ae9d15b53ef542ff129f988de74d04edcab984a3b4d09cf99b /exec failed with exit code 2
• Test CUDA Builds / test-models-cuda (add_mul) / linux-job (gh)
  RuntimeError: Command docker exec -t 4c572e7ec1722d62d5b1f21a6935790b40968349d1d120e2595535828cb23344 /exec failed with exit code 1
• Test CUDA Builds / test-models-cuda (add) / linux-job (gh)
  RuntimeError: Command docker exec -t 00011f550cb9f8bdc247c6f7fb80c6d728c39ca4bd92b2fd25b0b637b1972d7b /exec failed with exit code 1
• Test CUDA Builds / test-models-cuda (conv1d) / linux-job (gh)
  RuntimeError: Command docker exec -t ab97a54ce0e0df7860a0c18e2c8bfb97ecac44339c20c183ffdf1d9225fff235 /exec failed with exit code 1
• Test CUDA Builds / test-models-cuda (linear) / linux-job (gh)
  RuntimeError: Command docker exec -t f6891aacaee2123701e5568ce9bed0ed92b8a610b82c1fa1caea9a1aa2736163 /exec failed with exit code 1
• Test CUDA Builds / test-models-cuda (resnet18) / linux-job (gh)
  RuntimeError: Command docker exec -t 316b52a6c625402b04c173a0d37e69dbab7db8bf929664682d6e90a6d530fb6e /exec failed with exit code 1

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• pull / unittest / windows / windows-job (gh) (trunk failure)
  runtime/test/test_runtime_etdump_gen.py::RuntimeETDumpGenTest::test_etdump_params_with_bytes_and_buffer
• pull / unittest-editable / windows / windows-job (gh) (trunk failure)
  runtime/test/test_runtime_etdump_gen.py::RuntimeETDumpGenTest::test_etdump_params_with_bytes_and_buffer

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[StrycekSimon]

I saw the Samsung and CUDA tests failing on other PRs. The rest seems new but not relevant.

[StrycekSimon]

Please add unit tests for the newly supported variants of cat operator. If this is a feature of some future release of NC, then let's make this PR a draft until the NC version is bumped.

[jirioc]

Please add unit tests for the newly supported variants of cat operator. If this is a feature of some future release of NC, then let's make this PR a draft until the NC version is bumped.

It is supported in NC 25.09.

[jirioc]

Unit tests added.

[MartinPavella]

LGTM