Metal backend: Add operator implementations #15023
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15023
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit 61ead64 with merge base 6e0c9f6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 10, 2025
meta-cla
bot
added
the
CLA Signed
manuelcandales
requested review from
larryliu0820 and
mergennachin
and removed request for
cccclai and
shoumikhin
Comment on lines
+899
to
+902
| size_t query_size = query_tensor->numel() * element_size; | ||
| query_buffer = [device newBufferWithBytes:query_data_ptr | ||
| length:query_size | ||
| options:MTLResourceStorageModeShared]; |
There was a problem hiding this comment.
how and where do you clean this up?
Comment on lines
+1182
to
+1183
| // For attention weights, zero-fill the GPU buffer (shared memory allows CPU memset) | ||
| std::memset(attn_contents_ptr, 0, attn_size_bytes); |
There was a problem hiding this comment.
do you need zero filling here
|
|
||
| // Set output tensor handles | ||
| *ret0 = out_tensor_handle; | ||
| *ret1 = attn_tensor_handle; |
There was a problem hiding this comment.
Is ret1 actually populated or just zerod
manuelcandales
added
the
release notes: none
manuelcandales
added a commit
to manuelcandales/executorch-1
that referenced
this pull request
Oct 14, 2025
Adds bfloat16/float32 working implementations of the following AOTI shim ops: - aoti_torch_mps_mm_out - aoti_torch_mps_convolution - aoti_torch_mps__scaled_dot_product_attention_math_for_mps Adds a stub implementation of aoti_torch_mps_addmm_out ghstack-source-id: 61b8cc4 ghstack-comment-id: 3392300522 Pull-Request: pytorch#15023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds bfloat16/float32 working implementations of the following AOTI shim ops:
Adds a stub implementation of aoti_torch_mps_addmm_out