-
Notifications
You must be signed in to change notification settings - Fork 687
Add Post to backend stage to recipes #14990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Erik-Lundell
wants to merge
3
commits into
pytorch:main
Choose a base branch
from
Erik-Lundell:post_to_backend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+208
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a common pattern that passes require an exported program, which means that the pass needs to be constructed right before it is ran, with the correct exported program. Today there is no unified way this is done, which makes it tricky for general pass handling to figure out whether to pass an exported program to the constructor or not. This commit solves this by introducing a RequireExportProgram mixin, and makes a best effort to migirate passes to this system. Note that there are passes which require other arguments that still will break general pass handling. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: Ifaef3069fb04d6ab3df68b1d303aae7dc42585f2
After a discussion in pytorch#14588, it was decided to create an additional recipe stage to run passes after partitioning. This is meant for backends that convert ops directly instead of partitioning. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: Iddf74accb739d4dff16fa46c6fad88ffccfe2f3b
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14990
Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 New Failures, 4 Unrelated FailuresAs of commit b9843c2 with merge base 57a7903 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/trunk
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
partner: arm
For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
release notes: none
Do not include this in the release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PostToBackend stage to Recipes
After a discussion in #14588, it was decided to
create an additional recipe stage to run passes after partitioning.
This is meant for backends that convert ops directly instead of
partitioning.
Add RequireExportProgram mixin for passes
It is a common pattern that passes require an exported program,
which means that the pass needs to be constructed right before
it is ran, with the correct exported program. Today there is no
unified way this is done, which makes it tricky for general pass handling
to figure out whether to pass an exported program to the constructor or not.
This commit solves this by introducing a RequireExportProgram mixin,
and makes a best effort to migirate passes to this system.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai