Skip to content

Tag constants after quantization #14955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

Tag constants after quantization #14955

merged 1 commit into from
Oct 15, 2025

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Oct 9, 2025

Summary

Tag constants after quantization.

If we tag before quantization, the graph is mutated and tags are lost.

Test plan

CI (lora test)

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14955

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a2457a4 with merge base c9339e2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync Meta CodeSync
Copy link

meta-codesync bot commented Oct 9, 2025

@lucylq has imported this pull request. If you are a Meta employee, you can view this in D84278836.

@lucylq lucylq force-pushed the lfq.tag-constants-after-quant branch 3 times, most recently from 8f84f24 to afec819 Compare October 9, 2025 19:56
@lucylq lucylq marked this pull request as ready for review October 9, 2025 20:10
@lucylq lucylq requested a review from jackzhxng as a code owner October 9, 2025 20:10
digantdesai
digantdesai reviewed Oct 13, 2025
View reviewed changes
examples/models/llama/export_llama_lib.py
builder = builder_exported.pt2e_quantize(quantizers).to_edge_transform_and_lower(
partitioners
)
builder = builder_exported.pt2e_quantize(quantizers)
Copy link
Contributor

@digantdesai digantdesai Oct 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just moving here after pt2e_quantize or something else has also changed?

Copy link
Contributor Author

@lucylq lucylq Oct 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, splitting it so we can tag afterpt2e_quantize and before to_edge_transform_and_lower

@lucylq @facebook-github-bot
Tag constants after quantization (#14955)
a2457a4 
Summary:
Tag constants after quantization.

If we tag before quantization, the graph is mutated and tags are lost.


Test Plan: CI (lora test)

Differential Revision: D84278836

Pulled By: lucylq
@facebook-github-bot facebook-github-bot force-pushed the lfq.tag-constants-after-quant branch from afec819 to a2457a4 Compare October 14, 2025 22:57
@meta-codesync Meta CodeSync
Copy link

meta-codesync bot commented Oct 14, 2025

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84278836.

@lucylq lucylq merged commit db18577 into main Oct 15, 2025
142 of 150 checks passed
@lucylq lucylq deleted the lfq.tag-constants-after-quant branch October 15, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@GregoryComer GregoryComer Awaiting requested review from GregoryComer

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucylq @digantdesai