Skip to content

Export lora weights to sep file #14756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 11, 2025
Merged

Export lora weights to sep file #14756

merged 15 commits into from
Oct 11, 2025

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Oct 2, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Differential Revision: D83777195

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14756

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 007a293 with merge base 2eb8994 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

lucylq added a commit that referenced this pull request Oct 2, 2025
@lucylq
Export lora weights to sep file
dba2a56 
Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)

ghstack-source-id: 313704499
Pull Request resolved: #14756
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2025
@facebook-github-bot
Copy link
Contributor

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83777195.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This was referenced Oct 3, 2025
Merged
Closed
Merged
lucylq added a commit that referenced this pull request Oct 3, 2025
@lucylq
Export lora weights to sep file
0e66161 
Pull Request resolved: #14756


ghstack-source-id: 313704499
@exported-using-ghexport

Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
@lucylq lucylq changed the title Export lora weights to sep file [wip] Export lora weights to sep file Oct 3, 2025
lucylq added a commit that referenced this pull request Oct 6, 2025
@lucylq
Export lora weights to sep file
bfe947c 
Pull Request resolved: #14756


ghstack-source-id: 314404070
@exported-using-ghexport

Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
lucylq added a commit that referenced this pull request Oct 6, 2025
@lucylq
Export lora weights to sep file
a7fe5f5 
Pull Request resolved: #14756


ghstack-source-id: 314404070
@exported-using-ghexport

Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
lucylq added a commit that referenced this pull request Oct 6, 2025
@lucylq
Export lora weights to sep file
fc75dbb 
Pull Request resolved: #14756


ghstack-source-id: 314404070
@exported-using-ghexport

Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
lucylq added a commit that referenced this pull request Oct 6, 2025
@lucylq
Export lora weights to sep file
475a3b0 
Pull Request resolved: #14756


ghstack-source-id: 314404070
@exported-using-ghexport

Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
shoumikhin
shoumikhin reviewed Oct 7, 2025
View reviewed changes
examples/models/llama/main.cpp

#include <gflags/gflags.h>
#include <sstream>
#include <vector>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe some of these are already included by runer.h, etc

lucylq added a commit that referenced this pull request Oct 7, 2025
@lucylq
Export lora weights to sep file
1205207 
Pull Request resolved: #14756


ghstack-source-id: 314432731
@exported-using-ghexport

Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
@lucylq lucylq changed the title [wip] Export lora weights to sep file Export lora weights to sep file Oct 7, 2025
lucylq added a commit that referenced this pull request Oct 7, 2025
@lucylq
Export lora weights to sep file
3598f29 
Pull Request resolved: #14756


ghstack-source-id: 314455998
@exported-using-ghexport

Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
lucylq added a commit that referenced this pull request Oct 7, 2025
@lucylq
Export lora weights to sep file
a8cae2f 
Pull Request resolved: #14756


ghstack-source-id: 314455998
@exported-using-ghexport

Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
lucylq added a commit that referenced this pull request Oct 8, 2025
@lucylq
Export lora weights to sep file
80fa295 
Pull Request resolved: #14756


ghstack-source-id: 314455998
@exported-using-ghexport

Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
lucylq added a commit that referenced this pull request Oct 8, 2025
@lucylq
Export lora weights to sep file
97de2d0 
Pull Request resolved: #14756


ghstack-source-id: 314455998
@exported-using-ghexport

Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
lucylq added a commit that referenced this pull request Oct 9, 2025
@lucylq
Export lora weights to sep file
9934800 
Pull Request resolved: #14756


ghstack-source-id: 314455998
@exported-using-ghexport

Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
lucylq added a commit that referenced this pull request Oct 9, 2025
@lucylq
Export lora weights to sep file
f8cda78 
Pull Request resolved: #14756


ghstack-source-id: 314455998
@exported-using-ghexport

Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
lucylq added a commit that referenced this pull request Oct 9, 2025
@lucylq
Export lora weights to sep file
45f56cb 
Pull Request resolved: #14756


ghstack-source-id: 314455998
@exported-using-ghexport

Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
lucylq added a commit that referenced this pull request Oct 10, 2025
@lucylq
Export lora weights to sep file
fa17199 
Pull Request resolved: #14756


ghstack-source-id: 315259024
@exported-using-ghexport

Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
@meta-codesync meta-codesync bot merged commit ae8a996 into gh/lucylq/117/base Oct 11, 2025
277 of 282 checks passed
@meta-codesync meta-codesync bot deleted the gh/lucylq/117/head branch October 11, 2025 06:28
@pytorchbot pytorchbot mentioned this pull request Oct 11, 2025
Merged
lucylq added a commit that referenced this pull request Oct 12, 2025
@pytorchbot @lucylq
Export lora weights to sep file (#15035)
6ce53ca 
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #14756 by
@lucylq
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/lucylq/117/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/lucylq/117/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/lucylq/119/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/lucylq/117/orig
Differential Revision:
[D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
@diff-train-skip-merge

Co-authored-by: lucylq <lfq@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shoumikhin shoumikhin shoumikhin approved these changes

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucylq @facebook-github-bot @shoumikhin