[ET-VK][ez] Make get_tensor() API protected
#13168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that although the volume of changes in this diff are very high, the changes themselves are extremely mechanical. This diff was written almost entirely with a LLM, but I have looked through each file and validated the changes. ## Changes This diff updates callsites using `graph->get_tensor(value_ref)` in favor of just using the `ValueRef` directly. A simple example (and the vast majority of changes in this diff) is a change such as: ``` vTensorPtr tensor = graph->get_tensor(tensor_ref); some_fn(tensor->sizes()); ``` To instead be ``` std::vector<int64_t> tensor_sizes = graph->sizes_of(tensor_ref); some_fn(tensor_sizes); ``` or ``` some_fn(graph->sizes_of(tensor_ref)); ``` ## Motivation Overall, the goal is to make the `get_tensor()` API protected so that it can only be used in specific situations. In addition to the primary motivation of improving the consistency of API usage throughout the codebase, there is a practical benefit as well. `get_tensor` has a limitation that no values can be added to the graph while the `vTensorPtr` is in scope. Also, forcing tensor modifications via functions like `virtual_resize()` to go through the `ComputeGraph` will allow the graph to track changes for the purposes of determining when a command buffer re-encode or resize propagation is necessary, which will result in performance benefits. Differential Revision: [D79564594](https://our.internmc.facebook.com/intern/diff/D79564594/) ghstack-source-id: 301111044 Pull Request resolved: #13156
## Changes As title; make the `get_tensor()` API protected. ## Motivation See the below diff/PR in the stack. The goal is to encourage operator authors to go through the `ComputeGraph` to access/modify tensors so that the activity can be tracked. Differential Revision: [D79564596](https://our.internmc.facebook.com/intern/diff/D79564596/) ghstack-source-id: 301111043 Pull Request resolved: #13157
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13168
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
SS-JIA
approved these changes
Aug 6, 2025
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
## Changes As title; make the `get_tensor()` API protected. ## Motivation See the below diff/PR in the stack. The goal is to encourage operator authors to go through the `ComputeGraph` to access/modify tensors so that the activity can be tracked. Differential Revision: [D79564596](https://our.internmc.facebook.com/intern/diff/D79564596/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #13157 by @SS-JIA
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/268/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/268/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/267/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/268/orig
@diff-train-skip-merge