-
Notifications
You must be signed in to change notification settings - Fork 689
[ET-VK][ez] Small optimization to DynamicDispatchNode
#13159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes Update `DynamicDispatchNode` constructor so that `pick_global_wg_fn` does not need to be called multiple times. Differential Revision: [D79605482](https://our.internmc.facebook.com/intern/diff/D79605482/) [ghstack-poisoned]
This was referenced Aug 6, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13159
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 4 Unrelated FailuresAs of commit 5d6635d with merge base 6bc312a ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
SS-JIA
added a commit
that referenced
this pull request
Aug 6, 2025
## Changes Update `DynamicDispatchNode` constructor so that `pick_global_wg_fn` does not need to be called multiple times. Differential Revision: [D79605482](https://our.internmc.facebook.com/intern/diff/D79605482/) ghstack-source-id: 301111041 Pull Request resolved: #13159
This pull request was exported from Phabricator. Differential Revision: D79605482 |
trivedivivek
approved these changes
Aug 6, 2025
3750fcb
into
gh/SS-JIA/270/base
98 of 107 checks passed
SS-JIA
added a commit
that referenced
this pull request
Aug 7, 2025
Differential Revision: D79605482 Pull Request resolved: #13159
kirklandsign
pushed a commit
that referenced
this pull request
Aug 7, 2025
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
…3173) ## Context As title. pytorch#13158 and pytorch#13159 landed in Meta internal repo as diffs but there was a problem creating a merge PR. This PR manually adds the changes from those PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
release notes: vulkan
Changes to the Vulkan backend delegate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
DynamicDispatchNode
#13159DynamicDispatchNode
#13158get_tensor()
API protected #13157vTensorPtr
andget_tensor
#13156Changes
Update
DynamicDispatchNode
constructor so thatpick_global_wg_fn
does not need to be called multiple times.Differential Revision: D79605482