-
Notifications
You must be signed in to change notification settings - Fork 626
Turn BUILD_TESTING off if EXECUTORCH_BUILD_TESTS is off #12566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 23 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
9e3e2e7
Update
swolchok 16f0274
forgot to amend
swolchok 99ec5a7
Update
swolchok ff3cdb9
Update
swolchok 513de13
Update
swolchok 76db1f1
Update
swolchok 08bffac
Update
swolchok dff96c8
Update
swolchok 0e2bce6
Update
swolchok 35d8319
Update
swolchok a31187e
Update
swolchok dcbce0d
Update
swolchok bc8f971
Update
swolchok 29d3999
Update
swolchok 7e4040a
Update
swolchok 2dacf6f
Update
swolchok fb2b775
Update
swolchok 02f19a6
Update
swolchok 225d5a6
Update
swolchok 41bf264
Update
swolchok f54a8ce
Update
swolchok e48e6cc
Update
swolchok a2f14ac
Update
swolchok c31a4b9
Update
swolchok 4fd7372
Update
swolchok d650396
Update
swolchok 3bfdade
Update
swolchok 00acd77
Update
swolchok 6946143
Update
swolchok 431ddd8
Update
swolchok dcb3ca0
Update
swolchok 3c30b31
Update
swolchok e9928a7
Update
swolchok 05effc4
Update
swolchok 4c2e046
rebase
swolchok ccd0e2d
Update
swolchok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check how this behaves if you enable tokenizers? It uses abseil, which always includes CTest, which will turn on
BUILD_TESTING
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that's the third-party dep I was referring to, and that CTest won't turn on testing if it's already explicitly turned off.