Skip to content

[5.1/ N] set_option/get_option API with {backend_name, backend options} only #11865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 24, 2025

Conversation

cccclai
Copy link
Contributor

@cccclai cccclai commented Jun 23, 2025

Stack from ghstack (oldest at bottom):

This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR

Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too

Differential Revision: D77190316

…s} only

This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR

Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too

Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jun 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11865

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 441f673 with merge base 222d9e3 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 23, 2025
cccclai added a commit that referenced this pull request Jun 23, 2025
…s} only

This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR

Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too

Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)

ghstack-source-id: 292211297
Pull Request resolved: #11865
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77190316

…kend options} only"

This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR

Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too

Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)

[ghstack-poisoned]
cccclai added a commit that referenced this pull request Jun 24, 2025
…s} only

Pull Request resolved: #11865

This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR

Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
ghstack-source-id: 292211297

Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77190316

…kend options} only"

This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR

Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too

Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)

[ghstack-poisoned]
cccclai added a commit that referenced this pull request Jun 24, 2025
…s} only

Pull Request resolved: #11865

This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR

Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
ghstack-source-id: 292211297

Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
…kend options} only"

This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR

Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too

Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)

[ghstack-poisoned]
cccclai added a commit that referenced this pull request Jun 24, 2025
…s} only

Pull Request resolved: #11865

This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR

Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
ghstack-source-id: 292211297

Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
…kend options} only"

This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR

Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too

Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)

[ghstack-poisoned]
cccclai added a commit that referenced this pull request Jun 24, 2025
…s} only

Pull Request resolved: #11865

This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR

Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
ghstack-source-id: 292250319

Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77190316

…kend options} only"

This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR

Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too

Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)

[ghstack-poisoned]
cccclai added a commit that referenced this pull request Jun 24, 2025
…s} only

Pull Request resolved: #11865

This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR

Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
ghstack-source-id: 292255640

Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
…kend options} only"

This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR

Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too

Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)

[ghstack-poisoned]
cccclai added a commit that referenced this pull request Jun 24, 2025
…s} only

Pull Request resolved: #11865

This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR

Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
ghstack-source-id: 292257887

Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77190316

@facebook-github-bot facebook-github-bot merged commit 6e46c9d into gh/cccclai/31/base Jun 24, 2025
95 of 98 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/cccclai/31/head branch June 24, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants