Skip to content

Replaced int4 string with torch.int4 #11845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

Replaced int4 string with torch.int4 #11845

merged 1 commit into from
Jun 23, 2025

Conversation

rohansjoshi
Copy link
Contributor

Summary: "int4" was a placeholder for torch.int4 which has now been implemented (since PyTorch 2.6)

Reviewed By: cccclai

Differential Revision: D77058163

@rohansjoshi rohansjoshi requested a review from cccclai as a code owner June 22, 2025 21:25
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11845

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c511c34 with merge base 608a745 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 22, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77058163

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

rohansjoshi added a commit to rohansjoshi/executorch that referenced this pull request Jun 22, 2025
@rohansjoshi @facebook-github-bot
Replaced int4 string with torch.int4 (pytorch#11845)
81ef013 
Summary:

"int4" was a placeholder for torch.int4 which has now been implemented (since PyTorch 2.6)

Reviewed By: cccclai

Differential Revision: D77058163
@rohansjoshi @facebook-github-bot
Replaced int4 string with torch.int4 (pytorch#11845)
c511c34 
Summary:
Pull Request resolved: pytorch#11845

"int4" was a placeholder for torch.int4 which has now been implemented (since PyTorch 2.6)

Reviewed By: cccclai

Differential Revision: D77058163
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77058163

haowhsu-quic
haowhsu-quic approved these changes Jun 23, 2025
View reviewed changes
Copy link
Collaborator

@haowhsu-quic haowhsu-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@facebook-github-bot facebook-github-bot merged commit 695c7d5 into pytorch:main Jun 23, 2025
97 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai cccclai approved these changes

@haowhsu-quic haowhsu-quic haowhsu-quic approved these changes

@chunit-quic chunit-quic Awaiting requested review from chunit-quic

@shewu-quic shewu-quic Awaiting requested review from shewu-quic

@winskuo-quic winskuo-quic Awaiting requested review from winskuo-quic

@DannyYuyang-quic DannyYuyang-quic Awaiting requested review from DannyYuyang-quic

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rohansjoshi @facebook-github-bot @cccclai @haowhsu-quic