Skip to content

[ET-VK] New Implementation of `permute' operator #11825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: gh/SS-JIA/245/base
Choose a base branch
from

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Jun 20, 2025

Stack from ghstack (oldest at bottom):

Changes

  • Introduce permute_buffer.glsl and permute_texture.glsl compute shader templates to implement the permute operator

Motivation

The existing implementation of permute produced incorrect outputs for width packed textures. Furthermore, there was no buffer implementation for the permute operator.

My goal with this diff is to introduce a more flexible implementation of permute that could work for any tensor representation.

Performance impact

None expected.

Differential Revision: D76483755

## Changes

* Introduce `permute_buffer.glsl` and `permute_texture.glsl` compute shader templates to implement the permute operator

## Motivation

The existing implementation of permute produced incorrect outputs for width packed textures. Furthermore, there was no buffer implementation for the permute operator.

My goal with this diff is to introduce a more flexible implementation of permute that could work for any tensor representation.

## Performance impact

None expected.

Differential Revision: [D76483755](https://our.internmc.facebook.com/intern/diff/D76483755/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jun 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11825

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 69306da with merge base 608a745 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76483755

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

## Changes

* Introduce `permute_buffer.glsl` and `permute_texture.glsl` compute shader templates to implement the permute operator

## Motivation

The existing implementation of permute produced incorrect outputs for width packed textures. Furthermore, there was no buffer implementation for the permute operator.

My goal with this diff is to introduce a more flexible implementation of permute that could work for any tensor representation.

## Performance impact

None expected.

Differential Revision: [D76483755](https://our.internmc.facebook.com/intern/diff/D76483755/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76483755

## Changes

* Introduce `permute_buffer.glsl` and `permute_texture.glsl` compute shader templates to implement the permute operator

## Motivation

The existing implementation of permute produced incorrect outputs for width packed textures. Furthermore, there was no buffer implementation for the permute operator.

My goal with this diff is to introduce a more flexible implementation of permute that could work for any tensor representation.

## Performance impact

None expected.

Differential Revision: [D76483755](https://our.internmc.facebook.com/intern/diff/D76483755/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76483755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants