Create a MemoryPlanningAlgo class. #11824
Merged
+326
−224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11824
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 4 PendingAs of commit c610a30 with merge base da36d8a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76954785 |
zonglinpeng
approved these changes
Jun 23, 2025
hsharma35
force-pushed
the
export-D76954785
branch
from
9e9ffb5 to
4f94e1f
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Jun 23, 2025
Summary: Refactor our memory planning algos into a `MemoryPlanningAlgo` base class + algo-specific implementation in derived class. This refactor separates common utility functions + constraint handling to the base class. This way, we can add support for hierarchical graphs (using maps), and add more types of constraints (like pinning a tensor to specific dtcm bank) without changing the algo itself. Reviewed By: zonglinpeng Differential Revision: D76954785
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Jun 23, 2025
Summary: Pull Request resolved: pytorch#11824 Refactor our memory planning algos into a `MemoryPlanningAlgo` base class + algo-specific implementation in derived class. This refactor separates common utility functions + constraint handling to the base class. This way, we can add support for hierarchical graphs (using maps), and add more types of constraints (like pinning a tensor to specific dtcm bank) without changing the algo itself. Reviewed By: zonglinpeng Differential Revision: D76954785
hsharma35
force-pushed
the
export-D76954785
branch
from
4f94e1f to
a10c00e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76954785 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Jun 23, 2025
Summary: Refactor our memory planning algos into a `MemoryPlanningAlgo` base class + algo-specific implementation in derived class. This refactor separates common utility functions + constraint handling to the base class. This way, we can add support for hierarchical graphs (using maps), and add more types of constraints (like pinning a tensor to specific dtcm bank) without changing the algo itself. Reviewed By: zonglinpeng Differential Revision: D76954785
hsharma35
force-pushed
the
export-D76954785
branch
from
a10c00e to
5c536ab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76954785 |
Summary: Refactor our memory planning algos into a `MemoryPlanningAlgo` base class + algo-specific implementation in derived class. This refactor separates common utility functions + constraint handling to the base class. This way, we can add support for hierarchical graphs (using maps), and add more types of constraints (like pinning a tensor to specific dtcm bank) without changing the algo itself. Reviewed By: zonglinpeng Differential Revision: D76954785
hsharma35
force-pushed
the
export-D76954785
branch
from
5c536ab to
c610a30
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76954785 |
hsharma35
added
topic: not user facing
release notes: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactor our memory planning algos into a
MemoryPlanningAlgobase class + algo-specific implementation in derived class. This refactor separates common utility functions + constraint handling to the base class.This way, we can add support for hierarchical graphs (using maps), and add more types of constraints (like pinning a tensor to specific dtcm bank) without changing the algo itself.
Differential Revision: D76954785