-
Notifications
You must be signed in to change notification settings - Fork 602
Ability to specify full file configs for export_llm #11809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11809
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 6 PendingAs of commit 40d6a4a with merge base da36d8a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of the 0.7, one deliverable would be to swap the ci with the new API. Not in this PR though
executorch/.ci/scripts/test_llama.sh
Line 254 in 496cb05
$PYTHON_EXECUTABLE -m examples.models.llama.export_llama ${EXPORT_ARGS} |
# LICENSE file in the root directory of this source tree. | ||
|
||
# Install requirements for LLM extension | ||
pip install hydra-core>=1.3.0 omegaconf>=2.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just move these to https://github.com/pytorch/executorch/blob/main/requirements-dev.txt
extension/llm/export/README.md
Outdated
First, install the required dependencies: | ||
|
||
```bash | ||
./extension/llm/install_requirements.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly no need
Hydra is a bit opinionated on how config files should be provided to the CLI, this adds some tooling so that we can specify a config file from any arbitrary location to use with export_llm.
Example: