Skip to content

Ability to specify full file configs for export_llm #11809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2025

Conversation

jackzhxng
Copy link
Contributor

@jackzhxng jackzhxng commented Jun 19, 2025

Hydra is a bit opinionated on how config files should be provided to the CLI, this adds some tooling so that we can specify a config file from any arbitrary location to use with export_llm.

Example:

python -m extension.llm.export.export_llm --config ...some-path.../example_llm_config.yaml

[ghstack-poisoned]
@jackzhxng
Copy link
Contributor Author

jackzhxng commented Jun 19, 2025

Copy link

pytorch-bot bot commented Jun 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11809

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 6 Pending

As of commit 40d6a4a with merge base da36d8a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 19, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of the 0.7, one deliverable would be to swap the ci with the new API. Not in this PR though

$PYTHON_EXECUTABLE -m examples.models.llama.export_llama ${EXPORT_ARGS}

# LICENSE file in the root directory of this source tree.

# Install requirements for LLM extension
pip install hydra-core>=1.3.0 omegaconf>=2.3.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, install the required dependencies:

```bash
./extension/llm/install_requirements.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly no need

[ghstack-poisoned]
@jackzhxng jackzhxng mentioned this pull request Jun 20, 2025
[ghstack-poisoned]
[ghstack-poisoned]
@jackzhxng jackzhxng changed the title Ability to specify full file configs from anywhere Ability to specify full file configs for export_llm Jun 23, 2025
@jackzhxng jackzhxng merged commit d83636d into main Jun 23, 2025
102 checks passed
@jackzhxng jackzhxng deleted the gh/jackzhxng/24/head branch June 23, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants