[ET-VK][Ops] common test utils for converting aten types to vulkan types #11671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request resolved: #11575 # Context Most op test frameworks make use of common function utilities seeking to convert ATen scalartypes to ET vulkan scalartypes. In order to make this more accessible without having to constantly redefine these utility functions, this diff exists to migrate that. This will be re-used for quantization, dequantization, and choose_qparams operators. # Changes We migrate from_at_scalartype from existing test frameworks for operators. Currently this included `linear_weight_int4`, `rotary_embedding`, and `sdpa`. We also include more test utilities that are useful for understanding in plaintext the type error when throwing an exception. We need to modify the targets to ensure that the test utils is visible to all other files. ghstack-source-id: 290376486 @exported-using-ghexport Differential Revision: [D76464550](https://our.internmc.facebook.com/intern/diff/D76464550/)
pytorch-bot
bot
added
the
module: vulkan
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11671
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 9eb1daa with merge base 56392aa ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
ahmtox
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #11575 by @ahmtox
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/ahmtox/23/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/ahmtox/23/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/ahmtox/7/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/ahmtox/23/orig
@diff-train-skip-merge
cc @SS-JIA @manuelcandales @cbilgin