Skip to content

Use wrappers from xnnpack.h for unary and binary ops (#11584) #11666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

abhinaykukkadapu
Copy link

Summary

This PR uses xnn_define_binary and xnn_define_unary to define XNNPack ops, instead of separately calling the individual definitions.

Fixes #11584

Test plan

## Build steps
cmake -DEXECUTORCH_BUILD_XNNPACK=ON ..
cmake --build cmake-out -j9

Tests ran:
./test/run_oss_cpp_tests.sh
.
.
.
100% tests passed, 0 tests failed out of 86

Copy link

pytorch-bot bot commented Jun 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11666

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 2538d39 with merge base 56392aa (image):

NEW FAILURE - The following job has failed:

  • Lint / lintrunner / linux-job (gh)
    RuntimeError: Command docker exec -t ba96963fa04130bae9526a4509158f1cc3c983bd024de60ba704f0bbad047651 /exec failed with exit code 127

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 14, 2025
@abhinaykukkadapu
Copy link
Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Jun 14, 2025
@abhinaykukkadapu abhinaykukkadapu marked this pull request as ready for review June 14, 2025 16:48
@abhinaykukkadapu
Copy link
Author

lint runner failure seems unrelated. Local lint run is successful:

$ lintrunner -a
Warning: Could not find a lintrunner config at: '.lintrunner.private.toml'. Continuing without using configuration file.
  FLAKE8 success!
  CMAKE success!
  CLANGFORMAT success!
  UFMT success!
  ETCAPITAL success!
  NEWLINE success!
  NOTORCHINC success!
  NOSTDINC success!
  MYPY success!
  LICENSELINT success!
  TORCH_AO_IMPORT success!
ok No lint issues.
Successfully applied all patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to binary/unary subgraph
2 participants