Skip to content

Support for cmdline flag to toggle Debug vs Release build types in cmake #11662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BujSet
Copy link
Contributor

@BujSet BujSet commented Jun 13, 2025

Summary

Adds support for command line option to toggle the cmake build mode from Debug vs Release.

Test plan

An example use case is shown in examples/selective_build/test_selective_build.sh in the test_cmake_select_ops_in_model() function. For example, you could run the following to build executorch and run the test in Debug mode:

CMAKE_BUILD_TYPE=Debug bash examples/selective_build/test_selective_build.sh cmake

Copy link

pytorch-bot bot commented Jun 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11662

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 0a03aaa with merge base 56392aa (image):

NEW FAILURE - The following job has failed:

  • Lint / lintrunner / linux-job (gh)
    RuntimeError: Command docker exec -t fefef5eaeb55e6e42432f7e2c7ba90c2f19b16de793aa8a457e62af61ff83311 /exec failed with exit code 127

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@BujSet BujSet self-assigned this Jun 13, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 13, 2025
@BujSet BujSet added ciflow/trunk ciflow/binaries and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 13, 2025
@BujSet
Copy link
Contributor Author

BujSet commented Jun 13, 2025

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Jun 13, 2025
@BujSet BujSet marked this pull request as ready for review June 13, 2025 23:59
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 14, 2025
@BujSet BujSet force-pushed the cmake_build_type_cmdline_flag branch from 79f8c91 to 0a03aaa Compare June 14, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants