Arm backend: Fix sigmoid int16 and int32 flakyness #10548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10548
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 5137ab7 with merge base d7030aa ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
|
@digantdesai this is also steping Vela (e.g. it's newer then #9893 ) Maybe you want to merge both PRs at the same time using the version of Vela from this PR. EDIT we need to update this PR a bit more @digantdesai do not merge it yet |
|
Need to investigate some of the failures. |
MLBEDSW-10642 has now been resolved. Step vela pin and remove all related pytest.mark_flaky in sigmoid int16 and int32 tests. Also updates dw_conv2d tests as new constraints were introduced in vela compilation. Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: I8c1aff31fb173fa6fdebc1d5b757623f9c2e1321
oscarandersson8218
force-pushed
the
sigmoid_flaky_fix
branch
from
2120c63 to
5137ab7
Compare
|
@digantdesai @zingo It's now been resolved and is ready for review again. A few depthwise_conv2d tests started failing in different way than before so had to update those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step vela pin and remove all related pytest.mark_flaky in sigmoid int16 and int32 tests.
cc @digantdesai @freddan80 @per @zingo