Skip to content

Fix coreml rank0 #10534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix coreml rank0 #10534

wants to merge 5 commits into from

Conversation

metascroy
Copy link
Contributor

coremltools wraps rank 0 tensors as rank1 tensors in the AOT flow when producing a PTE file. This PR:

  • Applies the same change on the coreml runtime
  • Changes CoreML model tests to use the partitioner

Fixes #10451

Copy link

pytorch-bot bot commented Apr 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10534

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 65171cc with merge base c991de4 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

  • trunk / test-coreml-delegate / macos-job (gh) (trunk failure)
    /Users/runner/work/executorch/executorch/pytorch/executorch/backends/apple/coreml/runtime/test/ETCoreMLModelManagerTests.mm:220:28: error: member access into incomplete type 'const value_type' (aka 'const executorchcoreml::MultiArray')

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 28, 2025
@metascroy metascroy requested a review from YifanShenSZ April 28, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CoreML Partitioner is not able to lower mv3
3 participants