You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
## Changes
* In partitioner, check if buffer storage can be used only after it has
been determined that no valid texture layouts are available
## Context
Currently, the logic in the vulkan partitioner is incorrect.
1. First, it checks what texture layouts may be used to represent the
tensors involved in the computation
2. If no texture layouts are available, it checks if buffer support is
available and the tensors are small enough to be within Vulkan buffer
limits
3. Then, it checks if all valid texture layouts are supported by the op.
This introduces a bug in situations where 3 fails, but 2 would pass.
However, 2 is not checked due to the way the logic is structured.
The fix is to switch the order of 2 and 3.
Test Plan:
## Test Plan
Manual verification + CI
0 commit comments