add contiguous call to fix failing tests #2831
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73484645 |
Summary: There is a sneaky upstream bug (pytorch/pytorch#151978) that caused some unit tests to fail and broke max posterior sampling. This contiguous call resolves it for now, until the upstream fix goes in. Reviewed By: Balandat Differential Revision: D73484645
sdaulton
force-pushed
the
export-D73484645
branch
from
b883db6 to
31a602a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73484645 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2831 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 211 211
Lines 19241 19241
=========================================
Hits 19241 19241 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in de51252. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There is a sneaky upstream bug (pytorch/pytorch#151978) that caused some unit tests to fail and broke max posterior sampling. This contiguous call resolves it for now, until the upstream fix goes in.
Reviewed By: Balandat
Differential Revision: D73484645