Skip to content

Add suggested fix & PR fields to bug report template #2825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

saitcakmak
Copy link
Contributor

@saitcakmak saitcakmak commented Apr 15, 2025

As titled. Adds these two fields (tested in fork):
Screenshot 2025-04-15 at 2 45 20 PM

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 15, 2025
@saitcakmak saitcakmak marked this pull request as ready for review April 15, 2025 18:46
@facebook-github-bot
Copy link
Contributor

@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (74f144f) to head (35af6f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2825   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          211       211           
  Lines        19213     19213           
=========================================
  Hits         19213     19213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@facebook-github-bot
Copy link
Contributor

@saitcakmak merged this pull request in 67f34cb.

facebook-github-bot pushed a commit to facebook/Ax that referenced this pull request Apr 15, 2025
Summary:
Ax version of pytorch/botorch#2825

yaml rendering for Ax changes
<img width="858" alt="Screenshot 2025-04-15 at 2 49 14 PM" src="https://github.com/user-attachments/assets/d9adc30d-8ade-474e-b25c-8570f98ca3d6" />

BoTorch changes tested in fork
<img width="780" alt="Screenshot 2025-04-15 at 2 45 20 PM" src="https://github.com/user-attachments/assets/543edf88-eeb2-463b-9291-17fd06178dc1" />

Pull Request resolved: #3647

Reviewed By: Balandat

Differential Revision: D73053095

Pulled By: saitcakmak

fbshipit-source-id: ae91e9636ad7db7e4cb3309fd1e58a7b2a25817c
@saitcakmak saitcakmak deleted the saitcakmak-patch-1 branch May 29, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants