Skip to content

[BE] [float8] Run test_everything.sh in float8 test CI using linux.aws.h100.4 #2541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[BE] [float8] Run test_everything.sh in float8 test CI using linux.aws.h100.4 #2541

wants to merge 2 commits into from
+9 −1

Conversation

danielvegamyhre
Copy link
Contributor

Fixes #2477

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2541

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit 2530c2d with merge base c57226b (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 14, 2025
@danielvegamyhre danielvegamyhre added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jul 14, 2025
@danielvegamyhre
Copy link
Contributor Author

fyi @vkuzo

drisspg
drisspg reviewed Jul 14, 2025
View reviewed changes
.github/workflows/float8_test.yml
@@ -53,6 +53,11 @@ jobs:
uv pip install -r dev-requirements.txt
uv pip install vllm
pip install .
pytest test/float8 --verbose -s
pytest test/integration --verbose -s
pytest test/dtypes/test_affine_quantized_float.py --verbose -s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes tests

Copy link
Contributor Author

@danielvegamyhre danielvegamyhre Jul 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, added those back.

drisspg
drisspg requested changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@drisspg drisspg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the main way we are testing our integrations, add back

Also seems that there still exsits tests that can run non not 4 gpus that are worth doing

@danielvegamyhre
Copy link
Contributor Author

danielvegamyhre commented Jul 15, 2025 •
edited
Loading

Also seems that there still exsits tests that can run non not 4 gpus that are worth doing

Can you clarify what you mean here? We could use linux.aws.h100.8 for tests that require GPUs (e.g., 3d parallel). I have an in progress MoE test that requires 8 GPUs (#2481) but for the float8 distributed tests they require 4 max i believe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drisspg drisspg drisspg requested changes

Assignees
No one assigned
Labels
ci CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. float8 topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support running multi-device tests in CI
3 participants
@danielvegamyhre @drisspg @facebook-github-bot