enforce that MXTensor scale dimensions are consistent with data
#2506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2506
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Jul 8, 2025
Summary: Ensures that if the data dims are (M, K) then scale dims are (M, K // block_size). Previously the scale dims were (M, K // block_size, 1). No logic change in surrounding code, but this is definitely more correct. Test Plan: ``` pytest test/prototype/mx_formats ./test/prototype/mx_formats/test_mx_dtensor.sh ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 50e45ce ghstack-comment-id: 3049035188 Pull Request resolved: #2506
facebook-github-bot
added
the
CLA Signed
vkuzo
added
the
topic: not user facing
drisspg
approved these changes
Jul 8, 2025
vkuzo
added a commit
that referenced
this pull request
Jul 9, 2025
Summary: Ensures that if the data dims are (M, K) then scale dims are (M, K // block_size). Previously the scale dims were (M, K // block_size, 1). No logic change in surrounding code, but this is definitely more correct. Test Plan: ``` pytest test/prototype/mx_formats ./test/prototype/mx_formats/test_mx_dtensor.sh ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 50e45ce ghstack-comment-id: 3049035188 Pull Request resolved: #2506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Ensures that if the data dims are (M, K) then scale dims are (M, K //
block_size). Previously the scale dims were (M, K // block_size, 1).
No logic change in surrounding code, but this is definitely more
correct.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: