Skip to content

Rename torchao.float8.Float8Tensor to torchao.float8.Float8TrainingTensor #2479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2025

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Jul 2, 2025

Stacked PRs:


Rename torchao.float8.Float8Tensor to torchao.float8.Float8TrainingTensor

Summary:
att, since we are introducing a inference version Float8Tensor

Test Plan:
regression tests for float8 training: pytest test/float8

Reviewers:

Subscribers:

Tasks:

Tags:

Copy link

pytorch-bot bot commented Jul 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2479

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit b0acd5e with merge base e5ca515 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/11 branch from aacfea0 to 5fe4319 Compare July 2, 2025 21:42
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 2, 2025
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/4 to main July 2, 2025 23:44
@jerryzh168 jerryzh168 added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jul 2, 2025
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/11 branch from 5fe4319 to f9ba189 Compare July 2, 2025 23:44
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/4 July 2, 2025 23:44
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/4 to main July 3, 2025 00:09
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/11 branch from f9ba189 to 782b53f Compare July 3, 2025 00:09
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/4 July 3, 2025 00:09
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/4 to main July 3, 2025 02:18
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/11 branch from 782b53f to ea9092a Compare July 3, 2025 02:18
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/4 July 3, 2025 02:18
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/4 to main July 3, 2025 02:23
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/11 branch from ea9092a to 1b8c7cc Compare July 3, 2025 02:23
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/4 July 3, 2025 02:23
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/4 to main July 3, 2025 02:36
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/11 branch from 1b8c7cc to 2a00cd7 Compare July 3, 2025 02:36
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/4 July 3, 2025 02:36
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/4 to main July 3, 2025 02:37
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/4 July 3, 2025 02:38
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/4 to main July 3, 2025 02:44
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/11 branch from e00893c to 20ad3fb Compare July 7, 2025 19:57
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/4 July 7, 2025 19:57
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/4 to main July 7, 2025 22:39
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/4 July 7, 2025 22:39
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/4 to main July 7, 2025 23:14
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/4 July 7, 2025 23:14
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/4 to main July 7, 2025 23:27
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/4 July 7, 2025 23:28
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/4 to main July 8, 2025 00:14
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/4 July 8, 2025 00:15
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/4 to main July 8, 2025 02:27
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/11 branch from 20ad3fb to 9a4b4ef Compare July 8, 2025 02:27
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/4 July 8, 2025 02:27
Copy link
Contributor

@vkuzo vkuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test plan looks good, thank you!

@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/4 to main July 8, 2025 22:22
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/11 branch from 9a4b4ef to d487b79 Compare July 8, 2025 22:22
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/4 July 8, 2025 22:22
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/4 to main July 11, 2025 21:52
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/11 branch from d487b79 to ccf67a1 Compare July 11, 2025 21:52
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/4 July 11, 2025 21:53
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/4 to main July 11, 2025 23:05
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/11 branch from ccf67a1 to 53bb690 Compare July 11, 2025 23:05
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/4 July 11, 2025 23:06
…nsor

Summary:
att, since we are introducing a inference version Float8Tensor

Test Plan:
regression tests for float8 training: pytest test/float8

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2479, branch: jerryzh168/stack/11
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/4 to main July 11, 2025 23:45
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/11 branch from 53bb690 to b0acd5e Compare July 11, 2025 23:46
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/4 July 11, 2025 23:46
@jerryzh168 jerryzh168 merged commit 488340d into jerryzh168/stack/4 Jul 12, 2025
17 of 18 checks passed
jerryzh168 added a commit that referenced this pull request Jul 12, 2025
…nsor

Summary:
att, since we are introducing a inference version Float8Tensor

Test Plan:
regression tests for float8 training: pytest test/float8

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2479, branch: jerryzh168/stack/11
jerryzh168 added a commit that referenced this pull request Jul 12, 2025
Rename torchao.float8.Float8Tensor to torchao.float8.Float8TrainingTensor

Summary:
att, since we are introducing a inference version Float8Tensor

Test Plan:
regression tests for float8 training: pytest test/float8

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2479, branch: jerryzh168/stack/11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants